First PR for GSoD 2020 Interactive Book project #463
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| --- | |||
| {% include css/just-the-docs.scss.liquid color_scheme="circuitversedark" %} | |||
There was a problem hiding this comment.
Invalid CSS after "...uitversedark" %": expected "{", was "}"
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| --- | |||
| {% include css/just-the-docs.scss.liquid color_scheme="circuitverse" %} | |||
There was a problem hiding this comment.
Invalid CSS after "...circuitverse" %": expected "{", was "}"
| display: inline; | ||
| } | ||
| &.active { | ||
| list-style: disc url('/assets/images/nav-marker-active.svg') inside; |
| .nav-list-item { | ||
| .nav-list-link{ | ||
| display: inline; | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| list-style: circle url('/assets/images/nav-marker-inactive.svg') inside; | ||
|
|
||
| .nav-list-item { | ||
| .nav-list-link{ |
There was a problem hiding this comment.
Opening curly brace { should be preceded by one space
Selector should have depth of applicability no greater than 2, but was 3
|
|
||
| .main { | ||
| @include mq(md) { | ||
| position: relative; |
There was a problem hiding this comment.
Properties should be ordered margin-left, max-width, position
| min-width: $nav-width; | ||
| } | ||
| &.active { | ||
| display: none; |
There was a problem hiding this comment.
Line should be indented 4 spaces, but was indented 6 spaces
| @include mq(lg) { | ||
| width: calc((100% - #{$nav-width + $content-width}) / 4 + #{$nav-width}); | ||
| min-width: $nav-width; | ||
| } |
There was a problem hiding this comment.
@include declaration should be followed by an empty line
| } | ||
|
|
||
| @include mq(lg) { | ||
| width: calc((100% - #{$nav-width + $content-width}) / 4 + #{$nav-width}); |
There was a problem hiding this comment.
Properties should be ordered min-width, width
| background-color: $sidebar-color; | ||
|
|
||
| @include mq(md) { | ||
| flex-wrap: nowrap; |
There was a problem hiding this comment.
Properties should be ordered align-items, border-right, flex-direction, flex-wrap, height, position, width
|
@Shivansh2407 can you review this? |
Yeah Sure. |
There was a problem hiding this comment.
A glance of all the File Changes with screenshots is attached below:
Light Mode:
Search Light Mode:
404 Page:
Dark mode:
Search Dark Mode:
The Clean Install looks good to me and is working well @danielluehr . This is also working well in the mobile view. The Search Bar and the Side-Bar have a new and improved look and feel . Currently there is only page(/about) as in the screenshots above ( rest all pages have been removed ). The content pages will be added by Daniel in the upcoming PRs.
Great Work @danielluehr . Congratulations on your first PR 🎉 .
|
The Favicon needs to Be added, Dark Mode Can be Improved but these things can be done on later stages. Let me know your views @satu0king @danielluehr |
|
@Shivansh2407 , there is no netlify deployment here. Is it configured only for master branch? |
This is a first (test) PR for the GSoD 2020 Interactive Book project.
It is a "clean" jekyll + jtd + jekyll-spaceship setup. It includes 3 commits: