-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoD2020 Current book contents relocated into the new structure #478
Conversation
WARNING: _include/kmap.html had to be fixed since js was not being run on-load. In general, the include file seems wrong (it is a "full" page instead of just the pieces which are to be included).
WARNING: State Table Generator not running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working Well @danielluehr 🎉 .
- There are some links redirecting to learn.circuitverse.org, these will be changed later on section by section right?
- We can open an issue regarding the alignment of the list in the application1.html and other minor changes.
@satu0king Please review this.
@danielluehr why was this needed? We should be preferring relative links. Can you point out to specific files/lines where you changed this. |
About 1, that is correct, the links will be updated later. They should have been internal links and not "full" urls. The correct way would be:
That way, the links will be independent of the base url. |
Everywhere. Since all assets (js, images and css) are located in the same directory tree Besides that, having relative url to assets makes it very difficult to track where they are if the content is located at a different level in the
with absolute urls to assets it would be just: The only reason I have found to have relative urls pointing to assets would be to "preview" the page in github. However, the site is written to be parsed by jekyll to generate the static site. I don't think the "preview in github" without building it justify its usage. The same is true for links to pages, see: https://jekyllrb.com/docs/liquid/tags/#links Please let me know if there is an additional reason which should be considered and would justify going back to relative urls for assets. |
Ah, thanks for the clarification. You are right, it is better to have absolute URLs. |
The commits in this PR correspond to the relocation of the current contents into the new structure's chapters and sections.
Changes done:
{% link %}
tags