Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commitlint): enforce commit linting via git hooks #122

Merged
merged 1 commit into from Aug 4, 2021
Merged

Conversation

manjotsidhu
Copy link
Member

@manjotsidhu manjotsidhu commented Aug 4, 2021

Describe the changes you have made in this PR -

  • Added git's commit-msg hook in .githooks/commit-msg.
  • To use our custom githooks directory, we need to run git config core.hooksPath .githooks/.
  • commitlint should be installed globally to be able to run linting.
  • Added commit linting setup step in README.md

Screenshots of the changes (If any) -
image
image
image

Signed-off-by: Manjot Sidhu <manjot.techie@gmail.com>
@manjotsidhu manjotsidhu added the enhancement New feature or request label Aug 4, 2021
@manjotsidhu manjotsidhu self-assigned this Aug 4, 2021
@commit-lint
Copy link

commit-lint bot commented Aug 4, 2021

Features

  • commitlint: enable commit linting via git hooks (5682fc6)

Contributors

manjotsidhu

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@manjotsidhu manjotsidhu changed the title feat(commitlint): enable commit linting via git hooks feat(commitlint): enforce commit linting via git hooks Aug 4, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1097738396

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.472%

Totals Coverage Status
Change from base Build 1089169185: 0.0%
Covered Lines: 3880
Relevant Lines: 5210

💛 - Coveralls

@tachyons tachyons merged commit 940c6ba into master Aug 4, 2021
@tachyons tachyons deleted the cc-lint branch August 4, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants