Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoData handling is not ideal for condition1, condition2, condition1_future, and condition2_future #68

Closed
vlandau opened this issue Sep 17, 2020 · 1 comment

Comments

@vlandau
Copy link
Member

vlandau commented Sep 17, 2020

Currently, Circuitscape.read_raster overwrites NoData in the rasters with -9999. In (possibly rare) cases, the range of possible values for the condition rasters being fed into Omniscape could include -9999, so setting NoData pixels to -9999 in the array representation would mess things up.

I'm not sure the best way to handle this. One less-than-ideal option comes to mind:

  • Impose restrictions on the range of acceptable values for the condition layers so that -9999 is far enough away from the minimum value that it won't interfere with source-target matching.

For now, I'll update the docs to reflect this issue, but I will leave this open until I arrive at a better solution.

EDIT: Duh 🤦 I'll using missing.

@vlandau
Copy link
Member Author

vlandau commented Sep 17, 2020

Closing and dealing with this on #69

@vlandau vlandau closed this as completed Sep 17, 2020
vlandau pushed a commit that referenced this issue Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant