Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to the QueryBugsTest #162

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Fixes to the QueryBugsTest #162

merged 2 commits into from
Oct 22, 2023

Conversation

ChrisJollyAU
Copy link
Member

Upgrade the QueryBugsTest as it was out of date

@ChrisJollyAU ChrisJollyAU self-assigned this Oct 22, 2023
@ChrisJollyAU ChrisJollyAU merged commit 88f0ba8 into CirrusRedOrg:master Oct 22, 2023
6 of 8 checks passed
@lauxjpn
Copy link
Member

lauxjpn commented Oct 22, 2023 •
edited
Loading

@ChrisJollyAU Please don't merge PRs as long as the CI is failing. Fix the issues first, the push again and check the CI again. (I just changed the branch settings to enforce this policy in the future.)

ODBC:

The following 1 tests passed in previous runs, but didn't pass in this run:

EntityFrameworkCore.Jet.FunctionalTests.Query.QueryBugsTest.Access_property_of_closure_6864

OLE DB:

The following 7 tests passed in previous runs, but didn't pass in this run:

EntityFrameworkCore.Jet.FunctionalTests.Query.QueryBugsTest.Access_property_of_closure_6864
EntityFrameworkCore.Jet.FunctionalTests.Query.QueryBugsTest.Byte_enum_has_flag_does_not_apply_explicit_cast_for_non_constant
EntityFrameworkCore.Jet.FunctionalTests.Query.QueryBugsTest.Call_method_on_closure_6864
EntityFrameworkCore.Jet.FunctionalTests.Query.QueryBugsTest.Cast_to_implemented_interface_is_removed_from_expression_tree
EntityFrameworkCore.Jet.FunctionalTests.Query.QueryBugsTest.Cast_to_object_is_removed_from_expression_tree
EntityFrameworkCore.Jet.FunctionalTests.Query.QueryBugsTest.Correlated_collection_with_OfType_base
EntityFrameworkCore.Jet.FunctionalTests.Query.QueryBugsTest.Correlated_collection_works_when_defined_on_intermediate_type

All later CI runs have failed because of this. So these tests need to be fixed now ASAP (or the PR needs to be reverted).

@lauxjpn lauxjpn added this to the 8.0.0-alpha.2 milestone Oct 22, 2023
@ChrisJollyAU
Copy link
Member Author

Those tests don't exist anymore so its a bit hard for them to pass. Can safely be removed from the list of passing tests

lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 23, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
b3ab17b
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 23, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
7ccb2a7
@lauxjpn lauxjpn mentioned this pull request Oct 23, 2023
Merged
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 23, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
5521125
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 23, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
6cb7ea6
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 23, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
b1a7845
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 23, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
768e21e
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 23, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
42b313a
lauxjpn pushed a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 23, 2023
@ChrisJollyAU @lauxjpn
Fixes to the QueryBugsTest (CirrusRedOrg#162)
4f96e44 
* Ensure connection is closed before dropping the database/deleting the file

* Upgrade the QueryBugsTest
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 23, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
1e14292
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 24, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
87fdaec
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 25, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
51de34d
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 25, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
07b133d
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 25, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
918bea8
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 25, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
db32e57
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 25, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
c505df5
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 25, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
c0da857
lauxjpn added a commit to lauxjpn/EntityFrameworkCore.Jet that referenced this pull request Oct 25, 2023
@lauxjpn
Cleanup green tests after CirrusRedOrg#162.
f4a92fc
lauxjpn added a commit that referenced this pull request Oct 25, 2023
@lauxjpn
Fix auto commit for pull requests. (#165)
746f727 
* Fix auto commit for pull requests by using multiple workflows.

* Cleanup green tests after #162.

* [GitHub Actions] Update green tests.

---------

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ChrisJollyAU ChrisJollyAU

Labels
internal
Projects
None yet
Milestone
8.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChrisJollyAU @lauxjpn