Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility info for 8.0 series #181

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Add compatibility info for 8.0 series #181

merged 1 commit into from
Dec 4, 2023

Conversation

ChrisJollyAU
Copy link
Member

No description provided.

@ChrisJollyAU ChrisJollyAU self-assigned this Dec 4, 2023
@lauxjpn
Copy link
Member

lauxjpn commented Dec 4, 2023

Seems to be a bug in regards to our workflow, that explicitly does not trigger when only a *.md file changes, and the workflow validation, that expects the status job to run.

I'll fix it.

@lauxjpn
Copy link
Member

lauxjpn commented Dec 4, 2023

Okay, it should work now (the #182 test PR behaved the way we want it to).

@ChrisJollyAU
Copy link
Member Author

Well, the merge button is available, but it still looks to run all the tests anyway

@lauxjpn
Copy link
Member

lauxjpn commented Dec 4, 2023

It does definitely work for new PRs, even those that have been created using the GitHub interface (e.g. when making a change to the README.MD file directly on GitHub). It will only trigger a dummy workflow that will result in a successful status. Can be verified by taking a look a the still open #183 PR.

Its possible that this behaves differently for already existing PRs.

@ChrisJollyAU
Copy link
Member Author

Its possible that this behaves differently for already existing PRs.

Fair enough

@ChrisJollyAU ChrisJollyAU merged commit 79a19f1 into master Dec 4, 2023
9 of 10 checks passed
@ChrisJollyAU ChrisJollyAU deleted the ef8compat branch December 4, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants