Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DateTimeOffset Now and UtcNow #235

Merged
merged 4 commits into from
Mar 30, 2024

Conversation

ChrisJollyAU
Copy link
Member

  • Adds fixes for Now and UtcNow from DateTimeOffset. UtcNow will get the current offset in client and pass it to Jet to do the calculation
  • A DateTimeOffset with a DateTime portion 0f 0 will be translated to the 0 equivalent for Jet irrespective of its offset

@lauxjpn is this the right direction to go for these translations

@ChrisJollyAU ChrisJollyAU self-assigned this Mar 26, 2024
@ChrisJollyAU ChrisJollyAU merged commit 6ad6085 into CirrusRedOrg:master Mar 30, 2024
13 checks passed
@ChrisJollyAU ChrisJollyAU deleted the dtoffsetfix branch March 30, 2024 21:05
@lauxjpn
Copy link
Member

lauxjpn commented Apr 13, 2024

@lauxjpn is this the right direction to go for these translations

Yes, looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants