AdoX GetRelations returns all key types not just foreign keys #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetRelations function in AdoXSchema manages to return results for all found keys on a table. This includes primary keys and unique keys as well as foreign keys.
We only want the foreign keys.
GetRelationsColumns already does this so this is just making it consistent.
The DAO Schema querying works as expected and only returns the foreign keys.
Picked up as part of #241 where user had a one-to-one relationship and the child table had a foreign key and unique key that came back with the same name. As part of processing the returned results it tried to process the result that originally came with the unique key and as it had no principal table, resulted in a warning being generated.
This ensures we don't get to that point and all GetRelation schema (AdoX and DAO) return consistent results