Clam 2586 save urls html #1281
Open
Clam 2586 save urls html #1281
+505
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
from
638344d
to
73a2786
Compare
Kangie
reviewed
Jun 25, 2024
libclamav/scanners.c
Outdated
|
|
||
| bool bRet = false; | ||
|
|
||
| MATCH(str, "https://"); |
There was a problem hiding this comment.
There's a canonical list of URIs here and no reason I can see for limiting this to only 3 - if we're adding an option to extract URLs we should do it properly.
There was a problem hiding this comment.
I actually meant to go back and find a list once I had the code working, thank you!
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
2 times, most recently
from
dee0423
to
06bb01e
Compare
Thank you Matt Jolly for the helpful comment.
ragusaa
force-pushed
the
CLAM-2586-SaveUrlsHTML
branch
from
685401d
to
44832fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.