clam-1650 fixing leak when exporting pdf json metadata #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a block of code in cli_pdf with an '#if 0 ... #endif' around it. Could you remove that as part of the PR? |
|
Everything else looks good to me. I reproduced the issue in main, and verified that it is gone with your changes, so I'll go ahead and approve it. |
ragusaa
approved these changes
May 10, 2022
|
Could you also add a merge request to the private fuzz corpus? |
micahsnyder
approved these changes
May 28, 2022
Cleanup for the pdf->stats structure wasn't guaranteed when handling a fatal memory error. This fix pulls stats cleanup into its own function and handles the case where there's a fatal memory error by moving the function call below the err: tag. This fix also removes an extraneous call to pdf_export_json.
|
Rebased to see it go through the test pipelines with the PoC in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup for the pdf->stats structure wasn't guaranteed when handling
a fatal memory error. This fix pulls stats cleanup into its own function
and handles the case where there's a fatal memory error by moving the
function call below the err: tag.
This fix also removes an extraneous call to pdf_export_json.