Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDF object extraction recursion limits #629

Merged

Conversation

micahsnyder
Copy link
Contributor

Adds in object extraction recursion limits for object extraction as well
as well parsing string, array, and dictionaries during extraction.
The limit is set to 25.

libclamav/pdf.c Outdated Show resolved Hide resolved
libclamav/pdf.c Outdated Show resolved Hide resolved
libclamav/pdf.c Outdated Show resolved Hide resolved
@micahsnyder micahsnyder added the 🍒cherry-pick-candidate A PR that should be backported once approved. label Jul 18, 2022
Adds in object extraction recursion limits for object extraction as well
as well parsing string, array, and dictionaries during extraction.
The limit is set to 25.

Places recursion-depth variable in pdf parse context structure.
@micahsnyder
Copy link
Contributor Author

I squashed the fixup commits, rebased and resolved one minor merge conflict, and then added a commit to update the generated sys.rs file that was neglected in PR review from an unrelated PR. I figure this one will merge very shortly (soon as I see it pass testing)... and I want to get that sys.rs update in.

@micahsnyder micahsnyder merged commit c052dbe into Cisco-Talos:main Oct 21, 2022
@micahsnyder micahsnyder deleted the CLAM-1967-PDF-object-recursion branch May 7, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒cherry-pick-candidate A PR that should be backported once approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants