-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/health rules only #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iogbole
reviewed
Oct 28, 2020
AlexJov
commented
Oct 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test case
./start.sh -a Jenkins_API -c configmyappdemo-2044no-uzyczrm0.appd-cx.com -p appd -u appd --include-sim --health-rules-only | ||
echo Delete health rules: | ||
./start.sh -c http://configmyappdemo-2044no-uzyczrm0.appd-cx.com/ -a Jenkins_API -u appd -p appd --health-rules-delete "Agent Availability to Delete, Server Health: CPU Utilisation is too high to Delete" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still, here it shows like the Health Rule does not exist although I imported it in the previous step (line 101) :/
AlexJov
added a commit
that referenced
this pull request
Dec 2, 2021
* refactor app health rules (#27) * Feature/containerHealthRules (#28) * Feature/disable node hr (#29) * microservice health rules * Merge action-suppression and port-bugfix to develop from feature b; * Add action suppression upload from file; Typos; * Add suppress action config; * Add actions folder and example file; * Dash layout * Adding detele action suppression; * Controller port as parameter takes precedence; * Port controller; * Update create and delete action suppression; Update config; * Action suppression bugfix missing functions and folders; Save uploaded actions; * Action suppression adding proxy; Fix empty proxy; Backup only uploaded files; * Update action suppression help; * Rename dir healthrules to health_rules; * Add modules dir; Add health rule update / delete sh; * Add health rule only and delete options; * Update refs to HRs; Add debug echo; * Add delete health rule func; Remove debug from HR modules; * Add health rule vars to docker env and k8s configMap; * Remove health rule function from configMyApp; Update readme with argbash; * Delete HR from comma separated list; * HR override, support previous version of env. var; * Add git actions for health rules; * Update delete HR test case - delete multiple; * Update folder name in test case; * Add SIM HR to test case; * Test case update include sim flag; * Remove feature branch from actions; Co-authored-by: Israel Ogbole <iogbole@yahoo.com>
AlexJov
added a commit
that referenced
this pull request
Feb 14, 2022
* refactor app health rules (#27) * Feature/containerHealthRules (#28) * Feature/disable node hr (#29) * microservice health rules * Merge action-suppression and port-bugfix to develop from feature b; * Add action suppression upload from file; Typos; * Add suppress action config; * Add actions folder and example file; * Dash layout * Adding detele action suppression; * Controller port as parameter takes precedence; * Port controller; * Update create and delete action suppression; Update config; * Action suppression bugfix missing functions and folders; Save uploaded actions; * Action suppression adding proxy; Fix empty proxy; Backup only uploaded files; * Update action suppression help; * Rename dir healthrules to health_rules; * Add modules dir; Add health rule update / delete sh; * Add health rule only and delete options; * Update refs to HRs; Add debug echo; * Add delete health rule func; Remove debug from HR modules; * Add health rule vars to docker env and k8s configMap; * Remove health rule function from configMyApp; Update readme with argbash; * Delete HR from comma separated list; * HR override, support previous version of env. var; * Add git actions for health rules; * Update delete HR test case - delete multiple; * Update folder name in test case; * Add SIM HR to test case; * Test case update include sim flag; * Remove feature branch from actions; Co-authored-by: Israel Ogbole <iogbole@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add health rules only functionality;
Move health rule feature to the module;
Rename health rule folder containing json files;
Rename overwrite env variable and parameters (from overwrite_health_rules to health_rules_overwrite);
Add delete health rule by name (single);