Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of a filter plugin called aci_listify to the collection which flattens nested dictionaries #517

Merged
merged 7 commits into from
Nov 27, 2023
Merged

Addition of a filter plugin called aci_listify to the collection which flattens nested dictionaries #517

merged 7 commits into from
Nov 27, 2023

Conversation

shrsr
Copy link
Collaborator

@shrsr shrsr commented Oct 31, 2023

No description provided.

@shrsr
[minor_change] Addition of a filter plugin called aci_listify to the …
269b382 
…collection which flattens nested dictionaries
@shrsr shrsr self-assigned this Oct 31, 2023
@shrsr shrsr linked an issue Oct 31, 2023 that may be closed by this pull request
Upstream aci_listify as a generic Jinja plugin #146
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited

Codecov Report

Attention: 618 lines in your changes are missing coverage. Please review.

Comparison is base (939924a) 35.51% compared to head (9e7dbd2) 35.19%.
Report is 29 commits behind head on master.

❗ Current head 9e7dbd2 differs from pull request most recent head 47aba25. Consider uploading reports for the commit 47aba25 to get more accurate results

Files Patch % Lines
plugins/modules/aci_vrf_multicast.py 17.11% 92 Missing ⚠️
plugins/modules/aci_access_switch_policy_group.py 17.00% 83 Missing ⚠️
plugins/module_utils/aci.py 1.69% 58 Missing ⚠️
plugins/modules/aci_l3out_floating_svi_path.py 23.43% 49 Missing ⚠️
plugins/modules/aci_l3out_floating_svi.py 27.27% 40 Missing ⚠️
plugins/modules/aci_fabric_pod_selector.py 33.92% 37 Missing ⚠️
plugins/modules/aci_route_control_context.py 33.33% 32 Missing ⚠️
...odules/aci_l3out_floating_svi_path_secondary_ip.py 36.58% 26 Missing ⚠️
plugins/modules/aci_fabric_wide_settings.py 42.50% 23 Missing ⚠️
plugins/modules/aci_route_control_profile.py 42.10% 22 Missing ⚠️
... and 9 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
- Coverage   35.51%   35.19%   -0.33%     
==========================================
  Files         189      207      +18     
  Lines        8694     9602     +908     
  Branches     1287     1441     +154     
==========================================
+ Hits         3088     3379     +291     
- Misses       5606     6223     +617
Flag Coverage Δ
sanity 35.19% <32.01%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

samiib
samiib requested changes Nov 2, 2023
View reviewed changes
plugins/filter/listify.py Outdated Show resolved Hide resolved
akinross
akinross requested changes Nov 2, 2023
View reviewed changes
plugins/filter/listify.py Show resolved Hide resolved
plugins/filter/listify.py Show resolved Hide resolved
plugins/filter/listify.py Outdated Show resolved Hide resolved
velotiger added a commit to velotiger/ansible-role-aci-model that referenced this pull request Nov 5, 2023
@velotiger
Support a list of scalars as attr value in listify filter
eed6b9a 
Ref: CiscoDevNet/ansible-aci#517 (comment)
velotiger added a commit to velotiger/ansible-role-aci-model that referenced this pull request Nov 6, 2023
@velotiger
List of scalars as attr value in old listify filter
d07999d 
* This is a backport of
  commit eed6b9a
  to the old listify filter (aci.py).
* Add an example for a subnet to the example inventory.

Ref: CiscoDevNet/ansible-aci#517 (comment)
@shrsr shrsr requested a review from akinross November 14, 2023 17:23
akinross
akinross previously approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross akinross self-requested a review November 14, 2023 20:17
akinross
akinross previously approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr shrsr requested a review from akinross November 14, 2023 22:05
@shrsr shrsr requested a review from velotiger November 15, 2023 13:04
velotiger
velotiger approved these changes Nov 15, 2023
View reviewed changes
Copy link

@velotiger velotiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol requested changes Nov 15, 2023
View reviewed changes
plugins/filter/listify.py Outdated Show resolved Hide resolved
@shrsr shrsr requested a review from gmicol November 17, 2023 19:01
gmicol
gmicol approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 0e7af57 into CiscoDevNet:master Nov 27, 2023
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhercot lhercot lhercot approved these changes

@akinross akinross akinross approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@velotiger velotiger velotiger approved these changes

@gmicol gmicol gmicol approved these changes

@sajagana sajagana Awaiting requested review from sajagana

@samiib samiib Awaiting requested review from samiib

Assignees

@shrsr shrsr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upstream aci_listify as a generic Jinja plugin
7 participants
@shrsr @lhercot @akinross @anvitha-jain @velotiger @samiib @gmicol