Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module - meraki_mx_site_to_site_vpn #59

Closed
kbreit opened this issue Feb 5, 2020 · 8 comments · Fixed by #78
Closed

New module - meraki_mx_site_to_site_vpn #59

kbreit opened this issue Feb 5, 2020 · 8 comments · Fixed by #78
Assignees
Labels
new module Issue or pull request for a new module

Comments

@kbreit
Copy link
Collaborator

kbreit commented Feb 5, 2020

Meraki had support for configuring and querying site-to-site VPN information. A new module should be created to support this.

https://developer.cisco.com/meraki/api/#/rest/api-endpoints/networks/get-network-site-to-site-vpn

This issue is merged from ansible/ansible from issue request ansible/ansible#55997.

@kbreit kbreit added the new module Issue or pull request for a new module label Feb 5, 2020
@kbreit kbreit self-assigned this Feb 5, 2020
@kbreit
Copy link
Collaborator Author

kbreit commented Feb 8, 2020

@pokepoke81 - This module will be almost identical to meraki_mx_l3_firewall. With that in mind, I'm waiting to create meraki_mx_site_to_site_vpn until #62 is merged so I can take that bugfix and have it work in this module.

@kbreit
Copy link
Collaborator Author

kbreit commented Feb 16, 2020

@pokepoke81 I don't know if you'll be notified on the new PR, but please check out #68. Test and let me know if it works.

@kbreit
Copy link
Collaborator Author

kbreit commented Feb 17, 2020

Also, there isn’t an endpoint to configure site to site VPNs as far as I can tell. The best I can do is firewall rules for them.

@pokepoke81
Copy link
Contributor

pokepoke81 commented Feb 19, 2020

I'm trying to piece some things together. It seems that Site to Site VPN settings are defined in the Network: https://developer.cisco.com/meraki/api/#/python/api-endpoints/networks/update-network-site-to-site-vpn
You're right that there is a different endpoint for the VPN firewall.

So, do you have a separate module to add VLANs to the Site-to-Site VPN like the API? Or do you allow adding/editing them with the meraki_vlan module (which is how the dashboard works)?

This will also apply to static routes defined on the MX. https://community.meraki.com/t5/Developers-APIs/VPN-Static-Routes-through-API/m-p/50002

@pokepoke81
Copy link
Contributor

Also, I don't have a way to test your PR. I only have one organization and it's production. I'm testing the MS and MX stuff against spare hardware in the organization. I don't think that will work for me since VPN settings are across the organization, not the network.

@kbreit
Copy link
Collaborator Author

kbreit commented Feb 20, 2020

You may be able to create a new organization without licensing to test the module.

@pokepoke81
Copy link
Contributor

@kbreit I'm on a deadline this week, so haven't had a chance to get to this. Hopefully I can find a way to test it next week.

@kbreit
Copy link
Collaborator Author

kbreit commented Feb 26, 2020

No problem. Let me know when you're able to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Issue or pull request for a new module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants