meraki_mx_l3_firewall - Fix firewall rules not updating #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Any parameters with Any need to be capital except for protocol - Update integration tests
This was referenced Feb 8, 2020
kbreit
added a commit
to kbreit/ansible-meraki
that referenced
this pull request
Jun 20, 2020
* Fix lack of updates when there is only 1 real rule * Fix capitalization for Any - Any parameters with Any need to be capital except for protocol - Update integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firewall rules were not updating due to
range()not working if there was only one non-default firewall rule. This pull request fixes this. I also discovered a bug with integration tests whereanywasn't matching with the response from Meraki. I consulted Meraki and they clarified what I should expect. I've updated integration tests and documentation to reflect.Fixes #61
CC @pokepoke81