Skip to content
This repository has been archived by the owner on Aug 21, 2018. It is now read-only.

Iss07 #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Iss07 #21

wants to merge 3 commits into from

Conversation

cmlccie
Copy link
Contributor

@cmlccie cmlccie commented May 18, 2017

Indentation and whitespace corrections to fix #7.

I used the following process to make these corrections:

  • Used flake8 to identify the files with indentation issues.
  • Used PyCharm’s convert tabs to spaces feature (file by file) to make these changes.
  • Used the Reindent package to make number of spaces per indent consistent (4 spaces).
    • Manually reviewed reindent’s changes (spot checked each of the files).
  • Used flake8 to identify various under and over-indented line continuations.
  • Used flake8 to verify there were no remaining reporting indentation issues.

Tools and Commands Used

pip install flake8 Reindent

reindent -r -v .

flake8 . --select E101,E111,E114,E116,E122,E127,E128,E131,W191
--statistics

pip install Reindent
reindent -r -v .
<review changes comparing to *.bak>
Manually correct under and over-indented continuation lines.

Use the following package and command to identify and ‘verify’
corrections:
pip install flake8
flake8 . --select E101,E111,E114,E116,E122,E127,E128,E131,W191
--statistics
@annegentle
Copy link
Collaborator

Hey @cmlccie do you want any help with this merge?

@cmlccie
Copy link
Contributor Author

cmlccie commented Dec 14, 2017

I didn't have the rights to merge it. This PR is SO old, the work probably needs to be redone (as the code has likely changed).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize Python Indentation - Tabs or Spaces
2 participants