Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/hcl templates #34

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

msharma24
Copy link

I have made the following fixes and improvements to secure-firewall Terraform IAC.

AWS_Workshop/AWS_Workshop_Code/Resources

  1. Remove the template_file as Hashicorp has deprecated it- I have implemented the templatefile() Function
  2. I have also removed the hardcoded Ubuntu 20 AMI IDs from apps.tf and bastion.tf as the hardcoded AMI ids makes it hard to deploy and test in different regions of AWS. I have implemented the data resource to lookup the Ubuntu AMI id .

module - Network

  1. I have removed the template_file resource and implemented thetemplatefile() Function

I have deployed and tested the AWS_Workshop_Code - it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant