Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named configs and general refresher #130

Merged
merged 21 commits into from
Jun 14, 2024
Merged

Named configs and general refresher #130

merged 21 commits into from
Jun 14, 2024

Conversation

rschmied
Copy link
Member

@rschmied rschmied commented Jun 13, 2024

see CHANGELOG.md

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9512353194

Details

  • 88 of 122 (72.13%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 87.142%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/provider/resource/node/util.go 13 15 86.67%
internal/provider/resource/node/modify_plan.go 1 5 20.0%
internal/cmlschema/node.go 14 42 33.33%
Files with Coverage Reduction New Missed Lines %
internal/provider/datasource/users/users.go 1 88.16%
internal/provider/resource/lifecycle/meta.go 2 92.16%
Totals Coverage Status
Change from base Build 9005836632: -0.7%
Covered Lines: 3199
Relevant Lines: 3671

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9513796662

Details

  • 113 of 122 (92.62%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 88.314%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/provider/resource/node/util.go 13 15 86.67%
internal/cmlschema/node.go 39 42 92.86%
internal/provider/resource/node/modify_plan.go 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
internal/provider/datasource/users/users.go 1 88.16%
internal/provider/resource/lifecycle/meta.go 2 92.16%
Totals Coverage Status
Change from base Build 9005836632: 0.5%
Covered Lines: 3242
Relevant Lines: 3671

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9513796662

Details

  • 113 of 122 (92.62%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 88.341%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/provider/resource/node/util.go 13 15 86.67%
internal/cmlschema/node.go 39 42 92.86%
internal/provider/resource/node/modify_plan.go 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
internal/provider/datasource/users/users.go 1 88.16%
internal/provider/resource/lifecycle/meta.go 2 92.16%
Totals Coverage Status
Change from base Build 9005836632: 0.5%
Covered Lines: 3243
Relevant Lines: 3671

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9517456920

Details

  • 118 of 145 (81.38%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.08%) to 87.896%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/provider/resource/node/modify_plan.go 1 5 20.0%
internal/provider/resource/lifecycle/utilities.go 18 24 75.0%
internal/cmlschema/node.go 39 56 69.64%
Files with Coverage Reduction New Missed Lines %
internal/provider/datasource/users/users.go 1 88.16%
internal/provider/resource/lifecycle/meta.go 2 92.16%
Totals Coverage Status
Change from base Build 9005836632: 0.08%
Covered Lines: 3246
Relevant Lines: 3693

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9517456920

Details

  • 118 of 145 (81.38%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 87.923%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/provider/resource/node/modify_plan.go 1 5 20.0%
internal/provider/resource/lifecycle/utilities.go 18 24 75.0%
internal/cmlschema/node.go 39 56 69.64%
Files with Coverage Reduction New Missed Lines %
internal/provider/datasource/users/users.go 1 88.16%
internal/provider/resource/lifecycle/meta.go 2 92.16%
Totals Coverage Status
Change from base Build 9005836632: 0.1%
Covered Lines: 3247
Relevant Lines: 3693

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9519632042

Details

  • 118 of 145 (81.38%) changed or added relevant lines in 10 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 87.923%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/provider/resource/node/modify_plan.go 1 5 20.0%
internal/provider/resource/lifecycle/utilities.go 18 24 75.0%
internal/cmlschema/node.go 39 56 69.64%
Files with Coverage Reduction New Missed Lines %
internal/provider/resource/lifecycle/meta.go 2 92.16%
Totals Coverage Status
Change from base Build 9005836632: 0.1%
Covered Lines: 3247
Relevant Lines: 3693

💛 - Coveralls

@rschmied rschmied changed the title named configs and general refresher Named configs and general refresher Jun 14, 2024
@rschmied rschmied merged commit b0454f3 into main Jun 14, 2024
7 checks passed
@rschmied rschmied deleted the dev branch June 14, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants