Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named configs and general refresher #130

Merged
merged 21 commits into from
Jun 14, 2024
Merged

Named configs and general refresher #130

merged 21 commits into from
Jun 14, 2024

Conversation

rschmied
Copy link
Member

@rschmied rschmied commented Jun 13, 2024 •
edited
Loading

see CHANGELOG.md

rschmied added 18 commits May 8, 2024 14:19
@rschmied
Update terraform-plugin-docs to 0.19.2
0594101
@rschmied
Add test to replace link when changing slots
6b5bb34 
this is to test the code change for fixing #95 (test currently fails)
@rschmied
Ensure link gets replaced when slots are changes
cdf551c 
fixes #95
@rschmied
Implement link deletion
947549b 
- actually call API when deleting links
- needs updated gocmlclient 0.0.23
- do the slot replace link test slightly different
@rschmied
Use TF 1.7 and 1.8 instead of 1.4 and 1.6
a84feac
@rschmied
Add more steps to link slot test
82f77a8
@rschmied
Update dependencies
8079bc5
@rschmied
wip
3ff7bac
@rschmied
deprecate use_cache provider config
1bc0a0b
@rschmied
Make named configs work
7f196a5
@rschmied
Preparing release
8076470
@rschmied
More package updated
7ed6e07
@rschmied
Mark lifecycle.elements as deprecated
ffb41c7
@rschmied
Merge branch 'main' into dev
9d35837
@rschmied
elements deprecation and warning
1b6619d
@rschmied
Add token var to CI test
78b93f0
@rschmied
Increase integration test timeout from 5min to 1h
1e21675
@rschmied
Disable lifecycle check for deprecated elements attr
9322b58
@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9512353194

Details

  • 88 of 122 (72.13%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 87.142%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/provider/resource/node/util.go 13 15 86.67%
internal/provider/resource/node/modify_plan.go 1 5 20.0%
internal/cmlschema/node.go 14 42 33.33%
Files with Coverage Reduction New Missed Lines %
internal/provider/datasource/users/users.go 1 88.16%
internal/provider/resource/lifecycle/meta.go 2 92.16%
Totals Coverage Status
Change from base Build 9005836632: -0.7%
Covered Lines: 3199
Relevant Lines: 3671
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9513796662

Details

  • 113 of 122 (92.62%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 88.314%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/provider/resource/node/util.go 13 15 86.67%
internal/cmlschema/node.go 39 42 92.86%
internal/provider/resource/node/modify_plan.go 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
internal/provider/datasource/users/users.go 1 88.16%
internal/provider/resource/lifecycle/meta.go 2 92.16%
Totals Coverage Status
Change from base Build 9005836632: 0.5%
Covered Lines: 3242
Relevant Lines: 3671
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9513796662

Details

  • 113 of 122 (92.62%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 88.341%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/provider/resource/node/util.go 13 15 86.67%
internal/cmlschema/node.go 39 42 92.86%
internal/provider/resource/node/modify_plan.go 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
internal/provider/datasource/users/users.go 1 88.16%
internal/provider/resource/lifecycle/meta.go 2 92.16%
Totals Coverage Status
Change from base Build 9005836632: 0.5%
Covered Lines: 3243
Relevant Lines: 3671
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9517456920

Details

  • 118 of 145 (81.38%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.08%) to 87.896%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/provider/resource/node/modify_plan.go 1 5 20.0%
internal/provider/resource/lifecycle/utilities.go 18 24 75.0%
internal/cmlschema/node.go 39 56 69.64%
Files with Coverage Reduction New Missed Lines %
internal/provider/datasource/users/users.go 1 88.16%
internal/provider/resource/lifecycle/meta.go 2 92.16%
Totals Coverage Status
Change from base Build 9005836632: 0.08%
Covered Lines: 3246
Relevant Lines: 3693
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9517456920

Details

  • 118 of 145 (81.38%) changed or added relevant lines in 10 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 87.923%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/provider/resource/node/modify_plan.go 1 5 20.0%
internal/provider/resource/lifecycle/utilities.go 18 24 75.0%
internal/cmlschema/node.go 39 56 69.64%
Files with Coverage Reduction New Missed Lines %
internal/provider/datasource/users/users.go 1 88.16%
internal/provider/resource/lifecycle/meta.go 2 92.16%
Totals Coverage Status
Change from base Build 9005836632: 0.1%
Covered Lines: 3247
Relevant Lines: 3693
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9519632042

Details

  • 118 of 145 (81.38%) changed or added relevant lines in 10 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 87.923%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/provider/resource/node/modify_plan.go 1 5 20.0%
internal/provider/resource/lifecycle/utilities.go 18 24 75.0%
internal/cmlschema/node.go 39 56 69.64%
Files with Coverage Reduction New Missed Lines %
internal/provider/resource/lifecycle/meta.go 2 92.16%
Totals Coverage Status
Change from base Build 9005836632: 0.1%
Covered Lines: 3247
Relevant Lines: 3693
💛 - Coveralls

@rschmied rschmied changed the title named configs and general refresher Named configs and general refresher Jun 14, 2024
@rschmied rschmied merged commit b0454f3 into main Jun 14, 2024
7 checks passed
@rschmied rschmied deleted the dev branch June 14, 2024 18:23
This was referenced Jun 14, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rschmied @coveralls