-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.5.0 changes from BB #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschmied
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SIMPLE-5135 ResourcePoolUsage implementation SIMPLE-5124 - licensing status need not be filled SIMPLE-5095 Switch compute ID/resource pools to operational SIMPLE-5091 Fix recursion in _sync_resource_pools SIMPLE-5092 Change "id" to "pool_id" on resource pool syncup SIMPLE-5082 - add compute host management to PCL SIMPLE-4898 Update copyrights SIMPLE-4892 Update dependencies SIMPLE-4929 Cleanup authorization SIMPLE-4872 node state now forcibly updates if None SIMPLE-4858 - fix resource pool creation and user pools property SIMPLE-4554 PCL resource limiting implementation SIMPLE-2496 Migrated from 'requests' to 'httpx', simplified calls to API SIMPLE-4647 - Add client call for list of external bridges SIMPLE-2381 Validate image files before uploading SIMPLE-4534 Update packages SIMPLE-4263 Add isort to linters and run it across the code SIMPLE-4463: PCL support for node compute ID SIMPLE-4403 Fix ssl_verify and types in test_client_library_labs SIMPLE-4577 - allow bulk node updates; rename config to configuration SIMPLE-4160 added link label SIMPLE-4403 converted docstring type hints into type annotations, added new type annotations, fixed type issues reported by mypy SIMPLE-4606 Update packages SIMPLE-4389 Very bad walrus or how brackets are important sometimes SIMPLE-4389 We should not change the behavior but rather we should fix the docs SIMPLE-4313: update examples in client library docs SIMPLE-4313: remove redundant typing SIMPLE-4389 replaced Lab.get_link_by_interfaces/nodes with Interface/Node.get_link(s)_to, Interface deprecations SIMPLE-2605 import_sample_lab now uses sample/labs API endpoint, added get_sample_labs SIMPLE-4391 decreased severity of lab update logs from warning to info SIMPLE-4522 Properly replace all remaining deprecation warnings SIMPLE-4496 deprecated multiple Interface methods in favor of better ones SIMPLE-4451 pylama complexity issues SIMPLE-4483 replaced Lab.sync(with_node_configuration) argument with exclude_configurations SIMPLE-4461 logger renamed to _LOGGER, removed unused logging, logging.x changed to _LOGGER.x SIMPLE-4392 Exceptions were refactored: all exceptions moved to exceptions.py, new base exception, parent exception for Node/Link/InterfaceNotFound; all new exceptions inherit from the exceptions they replace, so no clientside changes should be necessary. SIMPLE-4393 further improved docstrings and typing SIMPLE-4392 Exceptions were refactored: all exceptions moved to exceptions.py, new base exception, parent exception for Node/Link/InterfaceNotFound; all new exceptions inherit from the exceptions they replace, so no clientside changes should be necessary. SIMPLE-4077 - add get_system_health call to client SIMPLE-4187 Fix SIMPLE-4349 Topology/lab/schema backward compatibility with 2.3 server SIMPLE-4187 sync lab states on ifc.state() call SIMPLE-4331: use learn_hostname in ClPyats SIMPLE-4221 Cherry-pick 2.3 stuff and update packages (python -> 3.7+) SIMPLE-4121 Add poweroff tests for all nodes SIMPLE-3991 mark test_node_shutdown as expected failure SIMPLE-4058 Verify HTTP transport SIMPLE-4067 Allow additional parameters when creating node and add tests to verify size limit for various endpoints SIMPLE-4022 Make integration tests license the instance before running SIMPLE-3992 The test should work SIMPLE-3991 mark test_node_shutdown as expected failure SIMPLE-4058 Verify HTTP transport SIMPLE-3617 Integration testing for VIRL topologies SIMPLE-4022 Make integration tests licese the instance before running SIMPLE-3944 Update copyright SIMPLE-3959 Set version to 2.4.0 and update dependencies SIMPLE-3991 mark test_node_shutdown as expected failure SIMPLE-3933 - add hostname param to get_pyats_testbed and lab SIMPLE-3890 add test case for node shutdown SIMPLE-3864 Improve integration tests for Groups SIMPLE-3865 Improve integration tests for User management SIMPLE-3829 - Add check on feature counts to SLR actions test SIMPLE-3808 Upgrade client version to 2.3.0 SIMPLE-3863 Improve integration tests for Node and Image definitions SIMPLE-3828 Add few missing negative SLR licensing tests. Cleanup. SIMPLE-3822 Make integration tests failsafe SIMPLE-3823 Move tests into more logical modules SIMPLE-3761 - expand import tests for additional properties SIMPLE-3758 - Rework client parameter passing and defaulting SIMPLE-3520 - Avoid delete with body and add licensing validation tests SIMPLE-3713 - Fix client node tag addition SIMPLE-3545 Remove deprecated images SIMPLE-3656 Remove invalid image definition SIMPLE-3600 Update library version in client library SIMPLE-3618 Integration test for YAML topologies with old schema versions SIMPLE-3580 Integration tests for Licensing feature - SLR base SIMPLE-3579 Integration tests for Licensing feature - license types SIMPLE-3563 Remove support for .ng (json) labs SIMPLE-3578 Integration tests for Licensing feature - registration negative cases SIMPLE-3574 Integration tests for Licensing feature - transport SIMPLE-3573 Integration tests for Licensing feature - certificate SIMPLE-3527 Change ID to UUID for lab elements Co-authored-by: Adrian Tulusak <atulusak@cisco.com> Co-authored-by: Daniel Valent <dvalent@cisco.com> Co-authored-by: Justin Guagliata <jguaglia@cisco.com> Co-authored-by: Miroslav Los <mirlos@cisco.com> Co-authored-by: Oliver Uhlar <ouhlar@cisco.com> Co-authored-by: Patrik Mosko <pmosko@cisco.com> Co-authored-by: Ralph Schmieder <rschmied@cisco.com> Co-authored-by: Tom Bryan <tombry@cisco.com>
rschmied
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks green now.
merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIMPLE-5135 ResourcePoolUsage implementation
SIMPLE-5124 - licensing status need not be filled
SIMPLE-5095 Switch compute ID/resource pools to operational
SIMPLE-5091 Fix recursion in _sync_resource_pools
SIMPLE-5092 Change "id" to "pool_id" on resource pool syncup
SIMPLE-5082 - add compute host management to PCL
SIMPLE-4898 Update copyrights
SIMPLE-4892 Update dependencies
SIMPLE-4929 Cleanup authorization
SIMPLE-4872 node state now forcibly updates if None
SIMPLE-4858 - fix resource pool creation and user pools property
SIMPLE-4554 PCL resource limiting implementation
SIMPLE-2496 Migrated from 'requests' to 'httpx', simplified calls to API
SIMPLE-4647 - Add client call for list of external bridges
SIMPLE-2381 Validate image files before uploading
SIMPLE-4534 Update packages
SIMPLE-4263 Add isort to linters and run it across the code
SIMPLE-4463: PCL support for node compute ID
SIMPLE-4403 Fix ssl_verify and types in test_client_library_labs
SIMPLE-4577 - allow bulk node updates; rename config to configuration
SIMPLE-4160 added link label
SIMPLE-4403 converted docstring type hints into type annotations, added new type annotations, fixed type issues reported by mypy
SIMPLE-4606 Update packages
SIMPLE-4389 Very bad walrus or how brackets are important sometimes
SIMPLE-4389 We should not change the behavior but rather we should fix the docs
SIMPLE-4313: update examples in client library docs
SIMPLE-4313: remove redundant typing
SIMPLE-4389 replaced Lab.get_link_by_interfaces/nodes with Interface/Node.get_link(s)_to, Interface deprecations
SIMPLE-2605 import_sample_lab now uses sample/labs API endpoint, added get_sample_labs
SIMPLE-4391 decreased severity of lab update logs from warning to info
SIMPLE-4522 Properly replace all remaining deprecation warnings
SIMPLE-4496 deprecated multiple Interface methods in favor of better ones
SIMPLE-4451 pylama complexity issues
SIMPLE-4483 replaced Lab.sync(with_node_configuration) argument with exclude_configurations
SIMPLE-4461 logger renamed to _LOGGER, removed unused logging, logging.x changed to _LOGGER.x
SIMPLE-4392 Exceptions were refactored: all exceptions moved to exceptions.py, new base exception, parent exception for Node/Link/InterfaceNotFound; all new exceptions inherit from the exceptions they replace, so no clientside changes should be necessary.
SIMPLE-4393 further improved docstrings and typing
SIMPLE-4392 Exceptions were refactored: all exceptions moved to exceptions.py, new base exception, parent exception for Node/Link/InterfaceNotFound; all new exceptions inherit from the exceptions they replace, so no clientside changes should be necessary.
SIMPLE-4077 - add get_system_health call to client
SIMPLE-4187 Fix
SIMPLE-4349 Topology/lab/schema backward compatibility with 2.3 server
SIMPLE-4187 sync lab states on ifc.state() call
SIMPLE-4331: use learn_hostname in ClPyats
SIMPLE-4221 Cherry-pick 2.3 stuff and update packages (python -> 3.7+)
SIMPLE-4121 Add poweroff tests for all nodes
SIMPLE-3991 mark test_node_shutdown as expected failure
SIMPLE-4058 Verify HTTP transport
SIMPLE-4067 Allow additional parameters when creating node and add tests to verify size limit for various endpoints
SIMPLE-4022 Make integration tests license the instance before running
SIMPLE-3992 The test should work
SIMPLE-3991 mark test_node_shutdown as expected failure
SIMPLE-4058 Verify HTTP transport
SIMPLE-3617 Integration testing for VIRL topologies
SIMPLE-4022 Make integration tests licese the instance before running
SIMPLE-3944 Update copyright
SIMPLE-3959 Set version to 2.4.0 and update dependencies
SIMPLE-3991 mark test_node_shutdown as expected failure
SIMPLE-3933 - add hostname param to get_pyats_testbed and lab
SIMPLE-3890 add test case for node shutdown
SIMPLE-3864 Improve integration tests for Groups
SIMPLE-3865 Improve integration tests for User management
SIMPLE-3829 - Add check on feature counts to SLR actions test
SIMPLE-3808 Upgrade client version to 2.3.0
SIMPLE-3863 Improve integration tests for Node and Image definitions
SIMPLE-3828 Add few missing negative SLR licensing tests. Cleanup.
SIMPLE-3822 Make integration tests failsafe
SIMPLE-3823 Move tests into more logical modules
SIMPLE-3761 - expand import tests for additional properties
SIMPLE-3758 - Rework client parameter passing and defaulting
SIMPLE-3520 - Avoid delete with body and add licensing validation tests
SIMPLE-3713 - Fix client node tag addition
SIMPLE-3545 Remove deprecated images
SIMPLE-3656 Remove invalid image definition
SIMPLE-3600 Update library version in client library
SIMPLE-3618 Integration test for YAML topologies with old schema versions
SIMPLE-3580 Integration tests for Licensing feature - SLR base
SIMPLE-3579 Integration tests for Licensing feature - license types
SIMPLE-3563 Remove support for .ng (json) labs
SIMPLE-3578 Integration tests for Licensing feature - registration negative cases
SIMPLE-3574 Integration tests for Licensing feature - transport
SIMPLE-3573 Integration tests for Licensing feature - certificate
SIMPLE-3527 Change ID to UUID for lab elements