Introduced multiple entities in filter for CRUD and Netconf dervices #713

ygorelik · 2018-03-15T00:08:54Z

Introduced multiple entities in filter for CRUD and Netconf dervices.

codecov · 2018-03-15T01:29:51Z

Codecov Report

Merging #713 into master will increase coverage by 0.34%.
The diff coverage is 89.93%.

@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
+ Coverage    78.8%   79.14%   +0.34%     
==========================================
  Files         171      172       +1     
  Lines       15785    15918     +133     
  Branches     1431     1431              
==========================================
+ Hits        12439    12599     +160     
+ Misses       3003     2975      -28     
- Partials      343      344       +1

Impacted Files	Coverage Δ
sdk/cpp/core/src/path/netconf_model_provider.cpp	`93.75% <ø> (ø)`	⬆️
...dk/python/core/tests/test_sanity_service_errors.py	`92.07% <ø> (ø)`	⬆️
sdk/python/core/ydk/services/crud_service.py	`100% <ø> (ø)`	⬆️
sdk/cpp/core/src/executor_service.cpp	`97.91% <ø> (+7.53%)`	⬆️
sdk/cpp/core/src/types.hpp	`94.11% <ø> (ø)`	⬆️
sdk/python/core/tests/test_sanity_netconf.py	`96.44% <100%> (+4.67%)`	⬆️
sdk/cpp/core/src/path/root_schema_node.cpp	`88.95% <100%> (+0.27%)`	⬆️
sdk/cpp/core/tests/core_test.cpp	`100% <100%> (ø)`	⬆️
sdk/cpp/core/src/path/repository.cpp	`87.69% <100%> (ø)`	⬆️
sdk/cpp/core/src/path/netconf_session.cpp	`86.25% <100%> (-0.06%)`	⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01689ee...8b26d0d. Read the comment docs.

ghost

Thanks, @ygorelik for this change!

ghost · 2018-03-15T18:49:06Z

sdk/cpp/core/src/common_utilities.cpp

+#include "xml_subtree_codec.hpp"
+
+using namespace std;
+using namespace ydk;


I think these functions need to be inside the ydk namespace as that is the convention being followed in the rest of the code. So this line can be removed and the below line can be used:
namespace ydk {

ghost · 2018-03-15T18:49:19Z

sdk/cpp/core/src/common_utilities.cpp

+//
+//////////////////////////////////////////////////////////////////
+
+#include "common_utilities.hpp"


Thanks for creating this utilities file!

ghost · 2018-03-15T18:52:34Z

sdk/cpp/core/src/common_utilities.cpp

+    return false;
+}
+
+string replace_xml_escape_sequences(const string& xml)


According to the codecov report, this function is not being tested. Can you please add a test case for this?

ghost · 2018-03-15T18:53:32Z

sdk/cpp/core/src/common_utilities.hpp

+#include "service_provider.hpp"
+
+using namespace std;
+using namespace ydk;


As mentioned below, these functions should be inside the ydk namespace.
namespace ydk {

ghost · 2018-03-15T18:54:48Z

sdk/cpp/core/src/common_utilities.hpp

+#include "logger.hpp"
+#include "service_provider.hpp"
+
+using namespace std;


Better to avoid having using namespace statements in header (.hpp) files. It is ok in .cpp files. See this link for why: https://stackoverflow.com/a/5849668

ghost · 2018-03-15T18:59:28Z

sdk/cpp/core/src/netconf_service.hpp

@@ -34,6 +34,8 @@
 #include "netconf_provider.hpp"
 #include "types.hpp"

+using namespace std;


Suggest not to add using namespace statements in .hpp files. See above comment.

ghost · 2018-03-15T19:00:54Z

sdk/cpp/core/src/path/netconf_session.cpp

-        YLOG_ERROR("Failed to get entity node.");
-        throw(YInvalidArgumentError{"Failed to get entity node"});
+    	return string{};
+//        YLOG_ERROR("Failed to get entity node.");


It may not be safe to comment out this exception. If the entity is empty, is it may be better to raise an exception instead of silently returning empty string?

ghost · 2018-03-15T19:01:28Z

sdk/cpp/core/src/path/path.cpp

+            std::free(buffer);
+        }
+
+        /*auto cdata_start = ret.find("<![CDATA[");


Suggest removing these lines instead of commenting out

ghost · 2018-03-15T19:02:27Z

sdk/cpp/tests/test_core_netconf.cpp

+
+    // Encode results
+    xml = s.encode(*read_result, ydk::EncodingFormat::XML, true);
+//    cout << endl << "===== XML after encoding multiple entities:" << endl << xml << endl;


Do these commented lines need to be removed?

ghost · 2018-03-15T19:02:31Z

sdk/cpp/tests/test_core_netconf.cpp

+    // Print after decoding
+//    vector<shared_ptr<ydk::path::DataNode>> data_nodes = data_node->get_children();
+//    for (auto dn : data_nodes) {
+//    	print_data_node(dn);


Do these commented lines need to be removed?

ghost · 2018-03-15T19:22:03Z

Also, codacy has some comments: https://app.codacy.com/app/ydk/ydk-gen/pullRequest?prid=1434270

Yan Gorelik added 4 commits March 13, 2018 10:00

Enhanced CrudService and NetconfService to work with multiple entities …

b725f81

…CiscoDevNet#121 and CiscoDevNet#123

Fixed code after merge with upstream

56036d4

Testing error in Travis

6f24c0b

Fixing travis test

eee8cff

Abhi Keshav and others added 3 commits March 14, 2018 22:43

Merge branch 'master' into master

c8feec1

Fixed Codacy issues

6a06ec0

Merge remote-tracking branch 'origin/master'

92a36ac

ghost suggested changes Mar 15, 2018

View reviewed changes

Yan Gorelik added 4 commits March 15, 2018 13:29

Fixed codacy issues

6ee5a8d

Fixed codacy issues

8277c20

Fixed code after review

7c57017

Fixed code after review

8b26d0d

ghost approved these changes Mar 15, 2018

View reviewed changes

ghost merged commit 6172a9a into CiscoDevNet:master Mar 16, 2018

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduced multiple entities in filter for CRUD and Netconf dervices #713

Introduced multiple entities in filter for CRUD and Netconf dervices #713

ygorelik commented Mar 15, 2018

codecov bot commented Mar 15, 2018 •

edited

Loading

ghost left a comment

ghost Mar 15, 2018

ghost Mar 15, 2018

ghost Mar 15, 2018

ghost Mar 15, 2018 •

edited by ghost

Loading

ghost Mar 15, 2018

ghost Mar 15, 2018

ghost Mar 15, 2018

ghost Mar 15, 2018

ghost Mar 15, 2018

ghost Mar 15, 2018

ghost commented Mar 15, 2018

Introduced multiple entities in filter for CRUD and Netconf dervices #713

Introduced multiple entities in filter for CRUD and Netconf dervices #713

Conversation

ygorelik commented Mar 15, 2018

codecov bot commented Mar 15, 2018 • edited Loading

Codecov Report

ghost left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost Mar 15, 2018 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Mar 15, 2018

codecov bot commented Mar 15, 2018 •

edited

Loading

ghost Mar 15, 2018 •

edited by ghost

Loading