Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced EntityCollection class and its aliases Filter and Config #719

Merged
9 commits merged into from
Mar 22, 2018

Conversation

ygorelik
Copy link
Collaborator

@ygorelik ygorelik commented Mar 22, 2018

Introduced EntityCollection class and its aliases Filter and Config. Added Python test cases to cover introduced code.

@codecov
Copy link

codecov bot commented Mar 22, 2018

Codecov Report

Merging #719 into master will increase coverage by 0.13%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #719      +/-   ##
=========================================
+ Coverage   79.47%   79.6%   +0.13%     
=========================================
  Files         172     173       +1     
  Lines       16139   16395     +256     
  Branches     1433    1471      +38     
=========================================
+ Hits        12826   13051     +225     
- Misses       2969    2987      +18     
- Partials      344     357      +13
Impacted Files Coverage Δ
sdk/python/core/ydk/types/__init__.py 100% <100%> (ø) ⬆️
sdk/python/core/tests/test_sanity_netconf.py 97.05% <100%> (+0.61%) ⬆️
sdk/python/core/tests/test_sanity_path.py 99.2% <100%> (+0.05%) ⬆️
sdk/python/core/ydk/models/__init__.py 100% <100%> (ø) ⬆️
...hon/core/tests/test_sanity_type_mismatch_errors.py 87.77% <100%> (ø) ⬆️
sdk/python/core/ydk/services/netconf_service.py 72.11% <68.42%> (-1.45%) ⬇️
sdk/python/core/ydk/services/crud_service.py 85% <71.42%> (-15%) ⬇️
sdk/python/core/ydk/types/py_types.py 78.8% <77.5%> (-0.41%) ⬇️
sdk/python/core/tests/test_ydk_types.py 97.8% <97.8%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abfc981...75d484d. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ygorelik !

@ghost ghost merged commit af3d36c into CiscoDevNet:master Mar 22, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant