Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update brew formulae, READMEs #362

Merged
5 commits merged into from
Jan 25, 2017
Merged

update brew formulae, READMEs #362

5 commits merged into from
Jan 25, 2017

Conversation

ylil93
Copy link
Contributor

@ylil93 ylil93 commented Jan 20, 2017

No description provided.

@ghost ghost added the in progress label Jan 20, 2017
@codecov-io
Copy link

codecov-io commented Jan 20, 2017

Current coverage is 83.52% (diff: 100%)

Merging #362 into master will increase coverage by 0.05%

@@             master       #362   diff @@
==========================================
  Files            98         98          
  Lines         11379      11379          
  Methods           0          0          
  Messages          0          0          
  Branches       1663       1663          
==========================================
+ Hits           9498       9504     +6   
+ Misses         1471       1467     -4   
+ Partials        410        408     -2   

Powered by Codecov. Last update cb522de...8171da0

@@ -46,13 +46,13 @@ YDK-Py requires ydk-cpp core to be built and installed.
####Linux
Ubuntu (Debian-based): The following packages must be present in your system before installing YDK-Py:
```
$ sudo apt-get install python-pip zlib1g-dev python-lxml libxml2-dev libxslt1-dev python-dev libboost-dev libboost-python-dev libssh-dev libcurl4-openssl-dev libtool-bin
$ sudo apt-get install python-pip zlib1g-dev python-lxml libxml2-dev libxslt1-dev python-dev libboost-dev libboost-python-dev libssh-dev libcurl4-openssl-dev libtool-bin bison curl doxygen flex git libboost-all-dev libboost-log-dev libcmocka0 libpcre3-dev libpcre++-dev libtool pkg-config python3-dev python3-lxml python-virtualenv software-properties-common unzip wget cmake
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bison curl doxygen flex git libcmocka0 pkg-config python-virtualenv software-properties-common unzip wget. These libraries are not directly related to ydk. I believe ydk will compile without these packages on ubuntu

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure pkg-config is not necessary on linux? I know it was required on mac

system requirements
@ghost ghost merged commit f97b710 into CiscoDevNet:master Jan 25, 2017
@ghost ghost removed the in progress label Jan 25, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants