Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider logging should indicate message directionality #388

Closed
111pontes opened this issue Feb 22, 2017 · 1 comment
Closed

Provider logging should indicate message directionality #388

111pontes opened this issue Feb 22, 2017 · 1 comment

Comments

@111pontes
Copy link
Collaborator

For providers that exchange messages, the directionality of those messages should be indicated (i.e. sent vs. received). While it can be inferred based on protocol knowledge, we can't assume that most users will have such expertise. Currently, YDK-Py logging for NETCONF provider looks like this:

2017-02-21 21:35:00,680 - ydk.services.crud_service - INFO - CREATE operation initiated
2017-02-21 21:35:00,682 - ydk.providers._provider_plugin - DEBUG –
<rpc xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="urn:uuid:d987d962-9374-4815-b335-ea6b8a62f2af">
  <edit-config>
    <target>
      <candidate/>
    </target>
    <config xmlns:xc="urn:ietf:params:xml:ns:netconf:base:1.0">
      <mpls-ldp xmlns="http://cisco.com/ns/yang/Cisco-IOS-XR-mpls-ldp-cfg">
        <default-vrf>
          <interfaces>
            <interface>
              <interface-name>GigabitEthernet0/0/0/0</interface-name>
              <enable></enable>
            </interface>
            <interface>
              <interface-name>GigabitEthernet0/0/0/1</interface-name>
              <enable></enable>
            </interface>
          </interfaces>
        </default-vrf>
        <enable></enable>
      </mpls-ldp>
    </config>
  </edit-config>
</rpc>

2017-02-21 21:35:00,947 - ydk.providers._provider_plugin - DEBUG –
<rpc-reply xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="urn:uuid:d987d962-9374-4815-b335-ea6b8a62f2af">
  <ok/>
</rpc-reply>

2017-02-21 21:35:00,948 - ydk.providers._provider_plugin - DEBUG –
<rpc xmlns="urn:ietf:params:xml:ns:netconf:base:1.0">
  <commit/>
</rpc>

2017-02-21 21:35:01,615 - ydk.providers._provider_plugin - DEBUG –
<rpc-reply xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="urn:uuid:d987d962-9374-4815-b335-ea6b8a62f2af">
  <ok/>
</rpc-reply>
@ghost
Copy link

ghost commented Mar 2, 2017

Fixed in ydk-cpp code. Will appear in ydk-py once the porting is done

@ghost ghost closed this as completed Mar 2, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant