Assorted changes #24
Assorted changes #24
Conversation
…comments and note that the default gateway is optional. Fixes launchpad bug #1090336 and a step towards booting disconnected hosts. May require some outstanding patches to cobbler to actually get the optional default gateway to work
…h0; break out the two functions
|
These look good to me, and I tested them previously. +1 |
|
... You never installed a control or compute node during these tests, I suspect... |
|
I didn't claim that I had. I said they looked good from a purely aesthetic perspective.... The nodes are building as we speak (or not) |
|
It looks as though we've got fixes for a variety of things here...what bugs do these propose to fix? |
|
Works, up to the point of external internet access. quantum starts and runs, bridges are set up, etc. |
|
Cleared the bugs related to this. |
Which were what? I think those include: https://bugs.launchpad.net/bugs/1090939 Any others? |
|
Also, who was the second reviewer on this? |
|
Shweta tested them, I believe. |
ghost
assigned
|
Shweta, can you that you've reviewed and tested this please? We really ought not be merging code that hasn't demonstrably been reviewed. |
|
I DID review and test. On Dec 18, 2012, at 5:14 AM, Mark T. Voelker <notifications@github.commailto:notifications@github.com> wrote: Shweta, can you that you've reviewed and tested this please? We really ought not be merging code that hasn't demonstrably been reviewed. — |
|
And that makes one person. Policy says two are necessary before the code gets merged. |
|
I am rebuilding my nodes with the merged changes. With Ians changes, The setup proceeded without any glitches. |
|
Uncle. On Dec 18, 2012, at 7:54 AM, "Mark T. Voelker" <notifications@github.commailto:notifications@github.com> And that makes one person. Policy says two are necessary before the code gets merged. — |
Includes no-net installation for pip