Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default loading of bonding module. #66

Merged

Conversation

michaeltchapman
Copy link

Change default loading of bonding module to false. Added optional parameter to enable.
https://bugs.launchpad.net/openstack-cisco/+bug/1167355

@robertstarmer
Copy link
Contributor

👍

@iawells
Copy link

iawells commented Apr 11, 2013

Why make it conditional, why not just load it and be damned?

Ian.

On 10 Apr 2013, at 22:58, "Robert Starmer" <notifications@github.commailto:notifications@github.com> wrote:

[:+1:]


Reply to this email directly or view it on GitHubhttps://github.com//pull/66#issuecomment-16218067.

@rickerc
Copy link
Member

rickerc commented Apr 11, 2013

Conditionalize because it creates a bond0 interface when loaded, which may prove confusing for the majority who don't have any bonded interfaces in play

@rickerc
Copy link
Member

rickerc commented Apr 11, 2013

The really long comment line needs to be line-wrapped

Other than that, +1

@iawells
Copy link

iawells commented Apr 11, 2013

Ah, ok. Not in a position to check the sources and I assumed it was only the kernel module.

Ian.

On 11 Apr 2013, at 06:56, "Chris Ricker" <notifications@github.commailto:notifications@github.com> wrote:

Conditionalize because it creates a bond0 interface when loaded, which may prove confusing for the majority who don't have any bonded interfaces in play


Reply to this email directly or view it on GitHubhttps://github.com//pull/66#issuecomment-16235794.

@ghost
Copy link

ghost commented Apr 11, 2013

+1

rickerc added a commit that referenced this pull request Apr 18, 2013
Disable default loading of bonding module.
@rickerc rickerc merged commit 0d48bc0 into CiscoSystems:multi-node Apr 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants