WIP: Readability and style updates #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed rabbit_hosts to use vip hostname instead of a list of actual controller addresses
…y-manifests into bugs/1206641 Conflicts: manifests/core.pp
|
Thanks for syncing up the HA manifest Pradeep....+1 on that patch from me. |
|
+1 on Mark's commits |
|
+1 to Mark's / Pradeep's |
markvoelker
pushed a commit
that referenced
this pull request
Aug 31, 2013
WIP: Readability and style updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of partial fixes for 1206641 and some of 1210645 as well as the two overlap in many cases. The end goal is to make our site/core manifests more self-documenting and easier for users to read and understand. I'll leave this open for a few days so folks can review and add additional cleanups to the topic branch, then we'll squash merge it later in the week. The commits I've already added below clarify language and provide a slew of puppet-lintish fixes that make the code easier to grock.