Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for complex interfaces+optionally bonding. #31

Merged
merged 2 commits into from May 29, 2013

Conversation

michaeltchapman
Copy link

@@ -31,7 +31,14 @@
} else {
$ra = $::ipv6_ra
}

if ($::interface_bonding == 'true'){
$bonding = 'echo "bonding" >> /target/etc/modules'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be $bonding = "echo 'bonding' >> /target/etc/modules"

@michaeltchapman
Copy link
Author

@rickerc look OK now? Actually the quotes are the other way around in the late_command sprintf.

@rickerc
Copy link
Member

rickerc commented May 29, 2013

+1

rickerc added a commit that referenced this pull request May 29, 2013
Add support for complex interfaces+optionally bonding.
@rickerc rickerc merged commit 8e3a7e5 into CiscoSystems:multi-node May 29, 2013
@danehans
Copy link

The interfaces template file looks as though it will break standard OpenStack deployments. Additionally, I originally used templates to control interfaces, but I found them to be too constraining to support various deployment models. Please review the example interface files in our HA and Folsom deployment guides for additional details:

http://docwiki.cisco.com/wiki/COE_Grizzly_Release:_High-Availability_Manual_Installation_Guide#Networking
http://docwiki.cisco.com/wiki/Cisco_OpenStack_Edition:_Folsom_Manual_Install

@iawells
Copy link

iawells commented May 29, 2013

I'm not sure what your issue is with standard deployments. As for your vlans, you're right that they cannot be templated - in those instances, though, you can't template the internal interface (which is really key to the bonding problem, because you can't change the default route post-install in any easy way, or its bonding config, because you cut yourself off from the puppetmaster) and then add the vlan aux interfaces with puppet.

@danehans
Copy link

The network module has been removed from the module list. Both interfaces are configured for static, when the interface used by OVS should be manual. The Grizzly manifests that I have been working on with Dan B use an interface dedicated for GRE tenant traffic isolation. Network interface definitions differ between Control, Compute, SLB and Swift Nodes. I'm all for adding bonding support, but I think we should keep the same network_config definitions and network module until we agree on a better way of managing interfaces.

Tehsmash pushed a commit to Tehsmash/grizzly-manifests that referenced this pull request Jul 12, 2013
Update rabbit/quantum user/pass, variables(1087359,1090422,1090338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants