Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plugin #16

Merged
merged 2 commits into from
Sep 20, 2013
Merged

Move plugin #16

merged 2 commits into from
Sep 20, 2013

Conversation

michaeltchapman
Copy link

Since the nexus puppetry needs more work
before it can be upstreamed, and the config
format will be changing in havana, this patch
moves the nexus puppetry into this module
and out of grizzly-manifests until it can
be re-done for havana in puppet-quantum.

Since the nexus puppetry needs more work
before it can be upstreamed, and the config
format will be changing in havana, this patch
moves the nexus puppetry into this module
and out of grizzly-manifests until it can
be re-done for havana in puppet-quantum.
@ghost
Copy link

ghost commented Aug 27, 2013

looks good to me.

@shmcfarl
Copy link

I needed to add import 'nexus' into the site.pp file or I get the error:
err: Could not retrieve catalog from remote server: Error 400 on SERVER: Puppet::Parser::AST::Resource failed with error ArgumentError: Could not find declared class coe::nexus at /etc/puppet/manifests/core.pp:472 on node control-server.example.com

@shmcfarl
Copy link

After resolving the import 'nexus' issue I then get:
err: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find template 'coe/nexus.ini.erb' at /etc/puppet/manifests/nexus.pp:15 on node control-server.example.com
warning: Not using cache on failed catalog
err: Could not retrieve catalog; skipping run

I removed the "coe/" out of line 15 of the nexus.pp line to read:
content => template('nexus.ini.erb')

And the puppet agent ran cleanly.

@michaeltchapman
Copy link
Author

"Could not find declared class coe::nexus"

Would happen if you had the wrong branch of puppet-coe checked out. I can't reproduce the behaviour you describe locally without using stock puppet-coe + the remove_nexus branch of grizzly-manifests, which is obviously not going to work since together they move the functionality from manifests to the coe module.

import 'nexus' should cause a failure because it will try to import a file called nexus in top scope. I can't explain why this is giving you positive results.

The 'coe/' in the path is the same as in the ceph classes in the coe module, and I get errors if it is removed. This matches what I would expect from the doc: http://docs.puppetlabs.com/guides/templating.html

@shwetaap
Copy link

Works as expected on my testbed

rickerc added a commit that referenced this pull request Sep 20, 2013
@rickerc rickerc merged commit 1516729 into CiscoSystems:grizzly Sep 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants