Resolve deprecation warning from NTP module #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markvoelker
commented
Feb 19, 2014
markvoelker
commented
|
👍 |
Some time back the folks at Puppet Labs deprecated the autoupdate parameter to the NTP module. However puppet-coi still invokes it, which causes a deprecation warning to be emitted: Notice: Scope(Class[Ntp]): autoupdate parameter has been deprecated and replaced with package_ensure. Set this to latest for the same behavior as autoupdate => true. This patch eliminates the deprecation warning by removing the deprecated parameter from our instantiation of the class. A corresponding change to puppet_openstack_builder will be submitted to map the package_ensure parameter to a variable used to manage a similar setting in other OpenStack classes. Partial-Bug: #1281896
|
https://review.openstack.org/#/c/75060/ for the pob data mapping |
|
+1 |
rickerc
added a commit
that referenced
this pull request
Feb 20, 2014
Resolve deprecation warning from NTP module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.