Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert trigalert #20

Merged
merged 6 commits into from
Feb 16, 2017
Merged

Add alert trigalert #20

merged 6 commits into from
Feb 16, 2017

Conversation

kosukemori
Copy link
Contributor

@kosukemori kosukemori commented Nov 7, 2016

Add alert and trigalert (for new REST API).
Also, I renamed sample.go to sample.txt, in order to avoid from coverall.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 77.093% when pulling 94ed0ce on add-alert-trigalert into dd3c8fc on develop.

@kosukemori kosukemori self-assigned this Feb 15, 2017
@kosukemori
Copy link
Contributor Author

@travelist Everyone forget to approve it...

Copy link

@lexholden lexholden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it would be a non-breaking change adding new functions only, and the tests pass, approving. LGTM unless @marcsolanas @johnugeorge @travelist have any objections.

@johnugeorge johnugeorge merged commit 1d72f3d into develop Feb 16, 2017
@kosukemori kosukemori deleted the add-alert-trigalert branch June 7, 2017 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants