For new authentication method #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 15, 2017 16:10
|
Randomized reviewers for this pull request: @yoelcabo |
Not necessary at the moment:) |
travelist
approved these changes
Jun 16, 2017
travelist
reviewed
Jun 16, 2017
zeus.go
Outdated
| } | ||
| if err != nil { | ||
| return []byte{}, 0, err | ||
| } | ||
| request.Header.Add("Authorization", "Bearer "+zeus.Token) | ||
| request.Header.Add("Bucket-Name", zeus.OrganizationAndBucket) |
There was a problem hiding this comment.
@kosukemori
If OrganizationAndBucket is "" (this means user did not call bucket("org/bucket") method), please skip this line.
This is for backward compatibility.
There was a problem hiding this comment.
@travelist
Isn't enough?
https://github.com/CiscoZeus/go-zeusclient/pull/21/files#diff-e5c1a3b943c1c3c19e6d4624f505427bR196
I thought that new go-client don't need to deal with external_token, is this correct?
|
I modified code to reset 'org/bucket' info. This prevent user to reuse same 'org/bucket' information without calling 'bucket' method. |
|
@kosukemori LGTM, Thank you!:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify for new authentication method in zeus.
Should we move from travis to codeship?