Enhance input validations #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xyhuang
commented
Jun 5, 2015
xyhuang
commented
- metric/log names validation
- dates validations
This improves the validation of metrics and logs names: - check whether the value is None - check name length - move the exception handlings to _validate*Name() methods
This improves the validation of from_date and to_date in getLogs() and getMetric(): - the dates must be either None or a number - the from_date cannot be later than to_date
This was referenced Jun 5, 2015
marcsolanas
added a commit
that referenced
this pull request
Jun 5, 2015
Merging pull request to enhance validations of user input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.