Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test ETH KnightingRound and Funding Variants #204

Open
dapp-whisperer opened this issue Jun 10, 2022 · 0 comments
Open

Test ETH KnightingRound and Funding Variants #204

dapp-whisperer opened this issue Jun 10, 2022 · 0 comments
Assignees
@Fatimanaz

Comments

@dapp-whisperer
Copy link
Contributor

These new variants take in native Ether rather than a token, and so need a slight varation.

Knighting Round with ETH

  • KnightingRoundWithEth has a new function, buyEth()
  • It also bricks the normal buy() function
  • The tokenIn doesn't matter, as it isn't used, but will be set as WETH

Funding with ETH

  • FundingWithEth has a new function depositEth()
  • It also bricks the normal depositFunction
  • ASSET address doesn't matter, but will be set as WETH

Should build off of this branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fatimanaz Fatimanaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fatimanaz @dapp-whisperer