Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KR fix #203

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

KR fix #203

wants to merge 7 commits into from

Conversation

dapp-whisperer
Copy link
Contributor

No description provided.

@dapp-whisperer dapp-whisperer mentioned this pull request Jun 10, 2022
Open
@Fatimanaz
Copy link
Collaborator

#204

@sajanrajdev
Copy link
Contributor

sajanrajdev commented Jun 16, 2022 •
edited
Loading

@Fatimanaz, the changes to the src/KnightingRoundWithEth.sol should also be tested. We should adapt the src/test/SetupAndKnightingRoundWithEth.t.sol and add the checks for the balance changes to the saleRecepient. Feel free to add any further checks to ensure the new functionalities are covered.

Other than this, tests are looking good.

@Fatimanaz
Copy link
Collaborator

Added more tests to check saleRecipient's balance of buyEth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajanrajdev sajanrajdev sajanrajdev left review comments

@Fatimanaz Fatimanaz Fatimanaz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dapp-whisperer @Fatimanaz @sajanrajdev