Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to toggle lights or make timed lights against monorail stations #1160

Closed
Adreos opened this issue Sep 23, 2021 · 5 comments
Closed

Unable to toggle lights or make timed lights against monorail stations #1160

Adreos opened this issue Sep 23, 2021 · 5 comments
Assignees
Labels
BUG Defect detected confirmed Represents confirmed issue or bug TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc
Milestone

Comments

@Adreos
Copy link

Adreos commented Sep 23, 2021

Describe the problem

Against monorail stations over roads, both the basic one and bus hub one, if an intersection is placed there a timed light cannot be set up, and the mod's use of light toggling cannot be setup. However other aspects of the mod can still be done, such as lane control and intersection properties.

This does not extend to normal monorail track away from the station, all mod properties function there fine.

I tested this on a new map with the only mods enabled being traffic manager and the vanilla mods of unlock all and unlimited money to rule out other mods as the problem.

Steps to reproduce

  1. Build a monorail station
  2. Build 2+roads coming off the end to form an intersection.
  3. Attempt to build a timed light on that intersection

Log files

output_log.txt

Savegame?

https://steamcommunity.com/sharedfiles/filedetails/?id=2609333149

Screenshots?

This busy intersection can only have lanes controlled but not a timed light to properly regulate it
20210923012050_1

Notes or questions?

Please let me know when the save game is no longer needed so I can remove it from my workshop.

@Adreos Adreos added BUG Defect detected triage Awaiting issue categorisation labels Sep 23, 2021
@Adreos Adreos changed the title Unable to toggle lights or maked timed lights against monorail stations Unable to toggle lights or make timed lights against monorail stations Sep 23, 2021
@krzychu124 krzychu124 added confirmed Represents confirmed issue or bug in-progress The problem is being solved currently TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc and removed triage Awaiting issue categorisation labels Sep 23, 2021
@krzychu124 krzychu124 added this to the 11.6.0 milestone Sep 23, 2021
@krzychu124
Copy link
Member

Thanks for reporting the issue. I also noticed similar behaviour with the metro/train/tram/trolleybus stations.
The issue is caused by the code for Movable Bridge mod compatibility😕
That mod has own custom logic for controlling traffic on the bridge that is incompatible with TM:PE so timed traffic lights cannot be set on any of those bridges. I need to figure out better solution.

@krzychu124 krzychu124 removed the in-progress The problem is being solved currently label Sep 24, 2021
@krzychu124 krzychu124 self-assigned this Sep 24, 2021
@krzychu124
Copy link
Member

@Adreos
I fixed the issue. I'll push an update to TM:PE TEST tomorrow.
If you want to test it locally here you can find the latest version with the fix

@krzychu124
Copy link
Member

Test workshop item updated. Closing.

@originalfoo originalfoo modified the milestones: 11.6.0, 11.6.1.3 Jan 18, 2022
@originalfoo
Copy link
Member

@krzychu124 I can't find the PR for this anywhere...

@krzychu124
Copy link
Member

@krzychu124 I can't find the PR for this anywhere...

Yeah, you won't find PR because... I accidentally merged that fix directly to master 192258e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Defect detected confirmed Represents confirmed issue or bug TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc
Projects
None yet
Development

No branches or pull requests

3 participants