Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUR compatibility - TM:PE version number #687

Closed
originalfoo opened this issue Feb 10, 2020 · 2 comments · Fixed by #688 or citiesskylines-csur/CSURToolBox#2
Closed

CSUR compatibility - TM:PE version number #687

originalfoo opened this issue Feb 10, 2020 · 2 comments · Fixed by #688 or citiesskylines-csur/CSURToolBox#2
Assignees
Labels
COMPATIBILITY Mod (in)compatibility / checker discussion Contains debate on certain topics EXTERNAL Mod conflict or other external factor help wanted Seeking assistance
Milestone

Comments

@originalfoo
Copy link
Member

@pcfantasy @kianzarrin @krzychu124 @kvakvs

I saw in citiesskylines-csur/CSURToolBox#1 that CSUR Toolbox won't patch TM:PE v11.1 or above?

Issue:

This means that the first 11.1 to hit LABS page is not going to have the CSUR road updates. It will likely be a second beta release to LABS that contains that code. Both will be v11.1

How do we handle this?

My suggestion is to use the C version, so 11.1.0, 11.1.1, etc. So the CSUR toolbox would need to check for TM:PE version 11.1.1 or above (11.1.0 will be beta1, 11.1.1 will be beta 2 with the CSUR code, etc).

In terms of STABLE releases, they'd get periodical deployments of known-good LABS releases, for example it might be something like 11.1.3 that gets pushed to STABLE.

@originalfoo originalfoo added feature A new distinct feature triage Awaiting issue categorisation labels Feb 10, 2020
@originalfoo originalfoo added this to the 11.1 milestone Feb 10, 2020
@originalfoo originalfoo self-assigned this Feb 10, 2020
@kvakvs
Copy link
Collaborator

kvakvs commented Feb 10, 2020

Publish LABS and let them catch up while its still in LABS?
Or minor versioning.

@originalfoo originalfoo added COMPATIBILITY Mod (in)compatibility / checker discussion Contains debate on certain topics EXTERNAL Mod conflict or other external factor help wanted Seeking assistance and removed feature A new distinct feature triage Awaiting issue categorisation labels Feb 10, 2020
@originalfoo
Copy link
Member Author

CSUR has been updated on workshop to check for TM:PE 11.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMPATIBILITY Mod (in)compatibility / checker discussion Contains debate on certain topics EXTERNAL Mod conflict or other external factor help wanted Seeking assistance
Projects
None yet
2 participants