Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lane arrows UI overlaps with timed traffic lights #824

Open
larssieboy18 opened this issue Apr 10, 2020 · 8 comments
Open

Lane arrows UI overlaps with timed traffic lights #824

larssieboy18 opened this issue Apr 10, 2020 · 8 comments
Assignees
Labels
BUG Defect detected confirmed Represents confirmed issue or bug LABS TM:PE LABS branch Overlays Overlays, data vis, etc. TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc UI User interface updates
Milestone

Comments

@larssieboy18
Copy link

larssieboy18 commented Apr 10, 2020

Hi,

In Traffic Manager 11.3 LABS, whenever I use the lane arrows UI, it overlaps with the symbol for timed traffic lights if it consists of 3 lanes (see attached). I might have changed the scale (not sure to be honest), but it is pretty annoying. If you need any more info, please let me know!

Screenshots?

Screenshot from Gyazo (expired)
Screenshot from Gyazo (GIF) (expired)


Best regards,
Lars

@larssieboy18 larssieboy18 added BUG Defect detected triage Awaiting issue categorisation labels Apr 10, 2020
@kvakvs
Copy link
Collaborator

kvakvs commented Apr 10, 2020

Anyone can suggest whether this is something i can fix with giving Z coord to the UI windows? @krzychu124 maybe you know. What's the Z used in overlay rendering and shaders?

@kvakvs kvakvs self-assigned this Apr 10, 2020
@originalfoo originalfoo added confirmed Represents confirmed issue or bug and removed triage Awaiting issue categorisation labels Apr 10, 2020
@originalfoo originalfoo added this to the 11.3.1 milestone Apr 10, 2020
@kvakvs
Copy link
Collaborator

kvakvs commented Apr 10, 2020

The overlays are rendered on top of everything even on top of the Game's own UI. Not sure if that's something I have introduced, but we surely can look into it.
bild

The overlays are rendered without Z coordinate, i might need some ideas here.

@originalfoo originalfoo added Overlays Overlays, data vis, etc. TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc UI User interface updates LABS TM:PE LABS branch labels Apr 11, 2020
@originalfoo originalfoo modified the milestones: 11.3.1, 11.4.0 Apr 11, 2020
@originalfoo
Copy link
Member

Dunno if it's any help, but I've just been wading throgh parking restrictions UI code and noticed the way it draws stuff:

GUI.DrawTexture(boundingBox, RoadUI.ParkingRestrictionTextures[allowed]);

So that's just splatting textures on to whatever is already on the screen (which is fast I guess).

So it seems the issue is when LegacySubTool.ShowGUIOverlay() is being called. If it's near the end of the rendering pipeline, then it's going to splat those icons on top of everything.

@originalfoo originalfoo modified the milestones: 11.5.0, 11.6.0 Apr 29, 2020
@kianzarrin
Copy link
Collaborator

@krzychu124 are we going to fix this by 11.6 or should I drop the milestone?

@kvakvs
Copy link
Collaborator

kvakvs commented Dec 21, 2021

My guess: This is caused by change in render order by the Sunset Harbour DLC.
For new speed limits overlay this is fixed by checking GUI rects for main menu, debug panel and speed limits panel.
For other overlays this is not fixed but can be fixed in the future.

@kianzarrin
Copy link
Collaborator

it is indeed annoying!
image

@krzychu124 krzychu124 modified the milestones: 11.6.0, Planned stuff Dec 21, 2021
@originalfoo
Copy link
Member

As an interim fix (and something to keep as it would be useful for screenshots) could the lane arrows window be made draggable (accepting that it will still re-center on node when camera moves)?

@krzychu124
Copy link
Member

The issues is we are rendering overlays on the GUI camera. OnGUI is called after rendering everything, including UI components...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Defect detected confirmed Represents confirmed issue or bug LABS TM:PE LABS branch Overlays Overlays, data vis, etc. TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc UI User interface updates
Projects
None yet
Development

No branches or pull requests

5 participants