OS-280 Dont fail on seeding essential wo app_configuration #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienhoorens
approved these changes
May 11, 2021
adessy
pushed a commit
that referenced
this pull request
Dec 16, 2022
…without-required-keys [CL-541] Disable features w/o required-settings in create_tenant.rake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reload_cl_settingsinitializer assumes an app_configuration record already exists, which is not always the case. db:seed succeeds when it is executed together with db:migrate, as in that case the initializer is only executed once at the start, but not when it runs in isolation.Also, the seeding is very slow because of the destroy_all on the CommonPassword table. The
delete_allsolves this.