-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CL-1097] Search by content from content builder #2542
Conversation
1f7466e
to
9cc8c33
Compare
1fed07f
to
90b9016
Compare
@sebastienhoorens @IvaKop do you agree that In my DB, it looks like that {
"en": {
"ROOT": {
"type": "div",
"nodes": ["nfXxt3641Y"],
"props": { "id": "e2e-content-builder-frame" },
"custom": {},
"hidden": false,
"isCanvas": true,
"displayName": "div",
"linkedNodes": {}
},
"1pzsxkGIsQ": {
...
},
"eLuxCVwxvY": {
"type": { "resolvedName": "Text" },
"nodes": [],
"props": { "text": "\u003cp\u003eqwe\u003c/p\u003e" },
"custom": {},
"hidden": false,
"parent": "4-5gDdwOpm",
"isCanvas": false,
"displayName": "Text",
"linkedNodes": {}
}
}
} |
@alexander-cit This is the case for the text component but I think there might be other content builder components where there might be relevant information for the search - like the title prop in the accordion, for example. Could you ask the methods squad for a comprehensive list? |
90b9016
to
aa337ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small typo fix, then this is good to go. :)
back/engines/commercial/content_builder/app/models/content_builder/patches/project.rb
Outdated
Show resolved
Hide resolved
back/engines/commercial/content_builder/config/initializers/pg_search.rb
Outdated
Show resolved
Hide resolved
96cfab4
to
2ac0d57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@alexander-cit Can we merge this beauty? 🍏 |
@nTraum I want to write one more test for it (search two projects against both content and body). I hope I'll do it today and then I'll merge. |
2ac0d57
to
e1251cd
Compare
No description provided.