Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-1097] Search by content from content builder #2542

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

alexander-cit
Copy link
Contributor

No description provided.

Base automatically changed from CL-1097-project-search to master August 16, 2022 09:55
@alexander-cit alexander-cit force-pushed the alexR-search-in-content-builder branch 2 times, most recently from 1f7466e to 9cc8c33 Compare August 16, 2022 10:08
@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Aug 16, 2022

Warnings
⚠️ The branch name contains no Jira issue key (case-sensitive)
⚠️ The changelog hasn't been modified
Messages
📖 Jira issue: CL-1097

Generated by 🚫 dangerJS against e1251cd

@alexander-cit alexander-cit force-pushed the alexR-search-in-content-builder branch 2 times, most recently from 1fed07f to 90b9016 Compare August 16, 2022 10:18
@alexander-cit
Copy link
Contributor Author

alexander-cit commented Aug 16, 2022

@sebastienhoorens @IvaKop do you agree that props.text (second level of nesting, hence *.* here) is the only valuable text we should search against?

In my DB, it looks like that

{
  "en": {
    "ROOT": {
      "type": "div",
      "nodes": ["nfXxt3641Y"],
      "props": { "id": "e2e-content-builder-frame" },
      "custom": {},
      "hidden": false,
      "isCanvas": true,
      "displayName": "div",
      "linkedNodes": {}
    },
    "1pzsxkGIsQ": {
    ...
    },
    "eLuxCVwxvY": {
      "type": { "resolvedName": "Text" },
      "nodes": [],
      "props": { "text": "\u003cp\u003eqwe\u003c/p\u003e" },
      "custom": {},
      "hidden": false,
      "parent": "4-5gDdwOpm",
      "isCanvas": false,
      "displayName": "Text",
      "linkedNodes": {}
    }
   }
}

@IvaKop
Copy link
Contributor

IvaKop commented Aug 16, 2022

@alexander-cit This is the case for the text component but I think there might be other content builder components where there might be relevant information for the search - like the title prop in the accordion, for example. Could you ask the methods squad for a comprehensive list?

Copy link
Contributor

@nTraum nTraum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small typo fix, then this is good to go. :)

Copy link
Contributor

@nTraum nTraum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nTraum
Copy link
Contributor

nTraum commented Aug 22, 2022

@alexander-cit Can we merge this beauty? 🍏

@alexander-cit
Copy link
Contributor Author

alexander-cit commented Aug 22, 2022

@nTraum I want to write one more test for it (search two projects against both content and body). I hope I'll do it today and then I'll merge.

@alexander-cit alexander-cit force-pushed the alexR-search-in-content-builder branch from 2ac0d57 to e1251cd Compare August 22, 2022 16:49
@alexander-cit alexander-cit merged commit 255935c into master Aug 22, 2022
@alexander-cit alexander-cit deleted the alexR-search-in-content-builder branch August 22, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants