TAN-1529 Strategic report template #8040
Conversation
|
| <li>${formatMessage(aboutMessages.projectLabel, { | ||
| projectsList: projectTitle?.[locale] ?? '', | ||
| })}</li> | ||
| <li> |
There was a problem hiding this comment.
Making this bold using <b> tags for consistency with Platform template
There was a problem hiding this comment.
Good to go!
Not directly related to this PR, but I'm wondering if we coul reduce repetitions in the design of some widgets when showing comparisons. Take for instance "Previous ... days" in the methods widget. This should in principle always be the same comparison for all the methods, so repeating it does not seem necessary. We have this issues with other widgets, but it's most noticeable here.
If we don't want to change the design now, I would at least try to tweak the width of the method box to fit two rows of 4 methods (since the number of methods is fixed and we cannot toggle them atm) and prevent the comparison line from wrapping.
...app/containers/Admin/reporting/components/ReportBuilder/Templates/PlatformTemplate/index.tsx
Outdated
Show resolved
Hide resolved
...app/containers/Admin/reporting/components/ReportBuilder/Templates/PlatformTemplate/index.tsx
Show resolved
Hide resolved
front/app/containers/Admin/reporting/components/ReportBuilder/TopBar/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
We should update the copy for messages.createReportModalTitle.
There was a problem hiding this comment.
(it would be nice to be able to confirm model with shift+enter)
| const [selectedProjectId, setSelectedProjectId] = useState< | ||
| string | undefined | ||
| >(); | ||
| const [dates, setDates] = useState<Dates>({ startDate: null, endDate: null }); | ||
|
|
||
| const [errorMessage, setErrorMessage] = useState<string | undefined>(); | ||
| const { formatMessage } = useIntl(); | ||
| const reportTitleTooShort = reportTitle.length <= 2; |
There was a problem hiding this comment.
Wondering why we have this restriction. If the customer wants to use sh**** names, they should be allowed to. (Also, we don't do that kind of check when renaming and it's not enforced by the BE either.)
There was a problem hiding this comment.
Idk, I think it would be weird to have reports that have a zero length name. So I think we should at least enforce a one character limit. But then why not two?
There was a problem hiding this comment.
Yeah, we definitely should not allow empty strings, but I think names with a length of 1 should be allowed. It's like naming files on your computer, it's up to the user to pick good names.
|
Also not super happy with the design, but not sure what to do to improve it. Fixing it can be a purely graphical change so it should be easy to fix later.
I can try this, but the widget will also be available for other screen sizes so this would of course only work for A4
It might still look bad in other languages though... |
Changelog