SkinTrait should only update if the Placeholder changes (#2703)

* Make SkinTrait only update when required * Add back skinName check
CitizensDev · Dec 12, 2021 · 13f7961 · 13f7961
1 parent 81404b4
commit 13f7961
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/main/src/main/java/net/citizensnpcs/trait/SkinTrait.java b/main/src/main/java/net/citizensnpcs/trait/SkinTrait.java
@@ -37,7 +37,7 @@ private void checkPlaceholder(boolean update) {
         if (skinName == null)
             return;
         String filled = ChatColor.stripColor(Placeholders.replace(skinName, null, npc).toLowerCase());
-        if (!filled.equalsIgnoreCase(skinName)) {
+        if (!filled.equalsIgnoreCase(skinName) && !filled.equalsIgnoreCase(filledPlaceholder)) {
             filledPlaceholder = filled;
             if (update) {
                 onSkinChange(true);