Adjust hologram mount strategy

CitizensDev · Oct 31, 2023 · 483b656 · 483b656
1 parent 401e34a
commit 483b656
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/main/src/main/java/net/citizensnpcs/trait/HologramTrait.java b/main/src/main/java/net/citizensnpcs/trait/HologramTrait.java
@@ -106,7 +106,6 @@ private NPC createHologram(String line, double heightOffset) {
             hologramNPC = registry.createNPC(EntityType.INTERACTION, line);
             hologramNPC.addTrait(new ClickRedirectTrait(npc));
             hologramNPC.data().set(NPC.Metadata.NAMEPLATE_VISIBLE, true);
-            hologramNPC.getOrAddTrait(MountTrait.class).setMountedOn(npc.getUniqueId());
         } else {
             hologramNPC = registry.createNPC(EntityType.ARMOR_STAND, line);
             hologramNPC.getOrAddTrait(ArmorStandTrait.class).setAsHelperEntityWithName(npc);
@@ -339,6 +338,10 @@ public void run() {
             if (updateName) {
                 nameLine.setText(npc.getRawName());
             }
+
+            if (useDisplayEntities && nameLine.hologram.getEntity().getVehicle() == null) {
+                npc.getEntity().addPassenger(nameLine.hologram.getEntity());
+            }
         }
 
         for (int i = 0; i < lines.size(); i++) {
@@ -359,6 +362,10 @@ public void run() {
                 hologramNPC.teleport(tp, TeleportCause.PLUGIN);
             }
 
+            if (useDisplayEntities && hologramNPC.getEntity().getVehicle() == null) {
+                npc.getEntity().addPassenger(hologramNPC.getEntity());
+            }
+
             String text = line.text;
             if (ITEM_MATCHER.matcher(text).matches()) {
                 hologramNPC.data().set(NPC.Metadata.NAMEPLATE_VISIBLE, false);