Fix legacy skull texture loading

CitizensDev · Jan 2, 2023 · aa59e15 · aa59e15
1 parent fda3c9d
commit aa59e15
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/main/src/main/java/net/citizensnpcs/Citizens.java b/main/src/main/java/net/citizensnpcs/Citizens.java
@@ -109,6 +109,8 @@ public void updateInventoryTitle(Player player, InventoryView view, String newTi
     private NPCSelector selector;
     private StoredShops shops;
     private final SkullMetaProvider skullMetaProvider = new SkullMetaProvider() {
+        private boolean SUPPORT_OWNER_PROFILE = true;
+
         @Override
         public String getTexture(SkullMeta meta) {
             GameProfile profile = NMS.getProfile(meta);
@@ -118,8 +120,22 @@ public String getTexture(SkullMeta meta) {
 
         @Override
         public void setTexture(String string, SkullMeta meta) {
-            UUID uuid = meta.getOwningPlayer() == null ? UUID.randomUUID() : meta.getOwningPlayer().getUniqueId();
-            NMS.setProfile(meta, new GameProfile(uuid, string));
+            GameProfile profile = NMS.getProfile(meta);
+            if (profile == null) {
+                if (SUPPORT_OWNER_PROFILE) {
+                    try {
+                        profile = new GameProfile(meta.getOwnerProfile().getUniqueId(),
+                                meta.getOwnerProfile().getName());
+                    } catch (Exception e) {
+                        SUPPORT_OWNER_PROFILE = false;
+                    }
+                }
+                if (profile == null) {
+                    profile = new GameProfile(UUID.randomUUID(), null);
+                }
+            }
+            profile.getProperties().put("textures", new Property("textures", string));
+            NMS.setProfile(meta, profile);
         }
     };
     private CitizensSpeechFactory speechFactory;

diff --git a/main/src/main/java/net/citizensnpcs/trait/ShopTrait.java b/main/src/main/java/net/citizensnpcs/trait/ShopTrait.java
@@ -189,7 +189,7 @@ public void changePage(int newPage) {
                 NPCShopItem item = shopPage.getItem(i);
 
                 if (item != null) {
-                    slot.setItemStack(item.display);
+                    slot.setItemStack(item.getDisplayItem(null));
                 }
 
                 final int idx = i;
@@ -405,7 +405,7 @@ public NPCShopItemEditor(NPCShopItem item, Consumer<NPCShopItem> consumer) {
         public void initialise(MenuContext ctx) {
             this.ctx = ctx;
             if (modified.display != null) {
-                ctx.getSlot(9 * 4 + 4).setItemStack(modified.display);
+                ctx.getSlot(9 * 4 + 4).setItemStack(modified.getDisplayItem(null));
             }
             ctx.getSlot(9 * 3 + 3).setItemStack(new ItemStack(Util.getFallbackMaterial("OAK_SIGN", "SIGN")),
                     "Set message to send on click, currently:",