Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player NPC always keeps chunks loaded #1947

Open
SupppRabit opened this issue Sep 12, 2019 · 6 comments

Comments

@SupppRabit
Copy link

commented Sep 12, 2019

When I create a player npc, it always keeps chunks loaded whether it is in the playerlist.
But the wiki shows if you issue /npc playerlist, it'll become a 'real' player and load chunks. That's to say if an npc is not a 'real' player, it won't keep chunks unless users get close.
When I'm in another world or far enough away from the npc and type /mem, it shows more chunks are loaded.
The config always-keep-loaded had already been set to false.

Server: Paper 1.14.4 - 187
Citizens: 2.0.25-SNAPSHOT (build 1746)

@ScuroK

This comment has been minimized.

Copy link

commented Sep 17, 2019

maybe thats why citizens is causing so much lag since 1.14.4 update?

@mcmonkey4eva

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

Citizens is not causing lag. 1.14 is lagging because 1.14 is a wreck.

@ScuroK

This comment has been minimized.

Copy link

commented Sep 17, 2019

i do agree. but however when i use "React-smart server performance" to detect lag, react would often report citizens as "guilty" plugin. after removing citizens and sentinel, my lag problems are much much better. it seems like it IS a minecraft issue BUT citizens seems to be very strongly affected by it.

@mcmonkey4eva

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

Plugins like that (and also the native timings system) are incredibly inaccurate at best. Use a legitimate profiler (like Warmroast, VisualVM, YourKit, ...) if you want useful perf tracing information.

@ScuroK

This comment has been minimized.

Copy link

commented Sep 17, 2019

ok. but removing citizens improved the situation so much that i am quite sure about it.

@fullwall

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

Not going to say that I understand the latest PlayerChunkMap code but something changed and may have broken this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.