Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 1.8 performance by not catching exceptions. #1697

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

mariaum
Copy link
Contributor

@mariaum mariaum commented Feb 9, 2019

Improves performance with 1.8 servers by not throwing and catching exceptions every tick for every NPC.
Not sure if this is the correct place, I am not familiar to the codebase.

@mcmonkey4eva
Copy link
Member

Seems like a reasonable solution there.
However also: Why are you running 1.8?! That's an ancient server version, and you should absolutely be updating. See relevant info page on wiki: https://wiki.citizensnpcs.co/Minecraft_1.8

@fullwall fullwall merged commit 7d7bf35 into CitizensDev:master Mar 7, 2019
@Matocolotoe
Copy link

Go and tell the same thing to Hypixel :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants