Optimize LookClose's findNewTarget #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod with some changes: -Build the list of all potential Players and THEN sort by distance. A good chunk of the method's time was spend sorting things it didn't need to. -Second, reorder the player checks for best performance, where getNPC() is the cheapest check and isPluginVanished is the most expensive check. In somewhat minimal testing, these changes almost dropped findNewTarget off of my profiling entirely
|
|
|
I don't know why the diff looks like it changes 100% of the lines. It's basically only |
|
Very likely carriage returns being removed/added. You can click the settings cog in the diff and hide whitespace changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can optimize a significant portion of LookClose's findNewTarget method with some changes:
-Build the list of all potential Players and THEN sort by distance. A good chunk of the method's time was spend sorting things it didn't need to including NPCs sorting amongst themselves.
-Second, reorder the player checks for best performance, where getNPC() is the cheapest check and isPluginVanished is the most expensive check.
In somewhat minimal testing, these changes almost dropped findNewTarget off of my profiling entirely
Here's the YK profiling of my live server with not that many people on, but this could easily scale poorly with upwards of 100 online, etc
