Clone vectors during pathfinding

CitizensDev · Nov 13, 2020 · 678ac65 · 678ac65
1 parent 67e6d4d
commit 678ac65
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/main/java/net/citizensnpcs/api/astar/pathfinder/FlyingBlockExaminer.java b/src/main/java/net/citizensnpcs/api/astar/pathfinder/FlyingBlockExaminer.java
@@ -29,7 +29,11 @@ public List<PathPoint> getNeighbours(BlockSource source, PathPoint point) {
                 for (int z = -1; z <= 1; z++) {
                     if (x == 0 && y == 0 && z == 0)
                         continue;
-                    neighbours.add(point.createAtOffset(point.getVector().add(new Vector(x, y, z))));
+                    Vector mod = point.getVector().clone().add(new Vector(x, y, z));
+                    if (mod.getY() < 0 || mod.getY() > 255 || mod.equals(point.getVector())) {
+                        continue;
+                    }
+                    neighbours.add(point.createAtOffset(mod));
                 }
             }
         }

diff --git a/src/main/java/net/citizensnpcs/api/astar/pathfinder/VectorNode.java b/src/main/java/net/citizensnpcs/api/astar/pathfinder/VectorNode.java
@@ -24,7 +24,7 @@ public VectorNode(VectorGoal goal, Location location, BlockSource source, BlockE
 
     public VectorNode(VectorNode parent, Vector location, PathInfo info) {
         super(parent);
-        this.location = location.setX(location.getBlockX()).setY(location.getBlockY()).setZ(location.getBlockZ());
+        this.location = new Vector(location.getBlockX(), location.getBlockY(), location.getBlockZ());
         this.info = info;
     }