MetadataStore no longer sets the default value in get()

CitizensDev · Feb 19, 2022 · fb163b8 · fb163b8
1 parent 833a086
commit fb163b8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/main/java/net/citizensnpcs/api/npc/MetadataStore.java b/src/main/java/net/citizensnpcs/api/npc/MetadataStore.java
@@ -21,8 +21,7 @@ public interface MetadataStore {
     <T> T get(NPC.Metadata key);
 
     /**
-     * Fetches metadata from the given key. Sets the default value provided via {@link #set(String, Object)} if the
-     * metadata is not already stored.
+     * Fetches metadata from the given key.
      *
      * @param key
      *            The key to get metadata from

diff --git a/src/main/java/net/citizensnpcs/api/npc/SimpleMetadataStore.java b/src/main/java/net/citizensnpcs/api/npc/SimpleMetadataStore.java
@@ -49,7 +49,6 @@ public <T> T get(String key) {
     public <T> T get(String key, T def) {
         T t = get(key);
         if (t == null) {
-            set(key, def);
             return def;
         }
         return t;