Mark alerts as triggered in DB when timer > threshold_timer #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current problem:
When
citoengine
receives multiple alerts of the same event within the same second, duplicated event actions are triggered.How to replicate?
Threshold Count
to1
andThreshold Timer
to60
.event_publisher.py
to send multiple alerts tocitoengine
within a second.Proposed Fix:
def is_action_required(self)
:if self.timer > self.event_action.threshold_timer
has to be the first condition.