Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initWithFrame: implementation to MBContactPicker to support usage ou... #62

Merged
merged 1 commit into from Feb 7, 2014

Conversation

mhupman
Copy link
Member

@mhupman mhupman commented Feb 7, 2014

...tside of a NIB context.

@mhupman
Copy link
Member Author

mhupman commented Feb 7, 2014

@MattCBowman In need of your AutoLayout-fu. I think there is a constraint issue that needs to be taken care of before merging this in. It seems like if MBContactPicker is initialized with a frame of CGRectZero the contained MBContactCollectionView never expands when the frame of the container (the MBContactPicker) grows.

I was able to get the collection view to be visible if I removed the call to disable translatesAutoResizingMaskIntoConstraints on the MBContactPicker, which leads me to believe there is an implicit constraint we might be missing.

Take a look at f71dc6a, I put a demo of the issue and my temporary workaround there.

@MattCBowman
Copy link
Member

🐛

@MattCBowman
Copy link
Member

If you want to manage layouts using frames, you'll need to turn on translatesAutoresizingMaskIntoConstraints on the MBContactPicker after initializing it. If you want to manage the layout manually, you can use constraints to place it in the proper location and size and not have to worry about turning on translatesAutoresizingMaskIntoConstraints.

mhupman added a commit that referenced this pull request Feb 7, 2014
Add initWithFrame: implementation to MBContactPicker to support usage ou...
@mhupman mhupman merged commit 76d71da into develop Feb 7, 2014
@mhupman mhupman deleted the feature/nib_free_usage branch April 17, 2014 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants